Local documentation searching does not work due to typo in JS link

Bug #456025 reported by Mary Gardiner
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
python2.6 (Ubuntu)
Fix Released
Undecided
Matthias Klose
Karmic
Fix Released
Low
Matthias Klose
Lucid
Fix Released
Undecided
Matthias Klose
python3.1 (Ubuntu)
Fix Released
Undecided
Unassigned
Karmic
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: python2.6

If I visit file:///usr/share/doc/python/html/search.html (in Firefox 3.5) I am told "Please activate JavaScript to enable the search functionality." Javascript is enabled in Firefox already. This results in unsearchable documentation.

This is a new bug in the karmic version of the documentation (or possibly the karmic version of Firefox).

ProblemType: Bug
Architecture: i386
Date: Tue Oct 20 15:43:31 2009
Dependencies: libjs-jquery 1.3.3-1ubuntu1
DistroRelease: Ubuntu 9.10
Package: python2.6-doc 2.6.4~rc1-1ubuntu1
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_AU.UTF-8
 PATH=(custom, no user)
 LANG=en_AU.UTF-8
 SHELL=/usr/bin/zsh
ProcVersionSignature: Ubuntu 2.6.31-14.46-generic
SourcePackage: python2.6
Uname: Linux 2.6.31-14-generic i686

Revision history for this message
Mary Gardiner (puzzlement) wrote :
Revision history for this message
Mary Gardiner (puzzlement) wrote :

Compare the behaviour of http://docs.python.org/search.html

Revision history for this message
Douglas Bagnall (douglasbagnall) wrote :

It's a typo in the symlink:

$ ls -al /usr/share/doc/python/html/_static/jquery.js
lrwxrwxrwx 1 root root 38 2009-10-30 16:48 /usr/share/doc/python/html/_static/jquery.js -> ../../../../javacript/jquery/jquery.js

That should be

../../../../javascript/jquery/jquery.js

not
../../../../javacript/jquery/jquery.js

(there's an "s" in "javascript")

summary: - Local documentation searching does not work in Firefox
+ Local documentation searching does not work due to typo in JS link
Revision history for this message
Douglas Bagnall (douglasbagnall) wrote :

The attached patch ought to work.

Matthias Klose (doko)
Changed in python2.6 (Ubuntu):
status: New → In Progress
Matthias Klose (doko)
Changed in python2.6 (Ubuntu Karmic):
importance: Undecided → Low
milestone: none → karmic-updates
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted python2.6 into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in python2.6 (Ubuntu Karmic):
assignee: nobody → Matthias Klose (doko)
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in python3.1 (Ubuntu Karmic):
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Accepted python3.1 into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python3.1 - 3.1.1-1ubuntu1

---------------
python3.1 (3.1.1-1ubuntu1) lucid; urgency=low

  * Update to the 3.1 release branch, 20091102.
  * distutils install: Don't install into /usr/local/local, if option
    --prefix=/usr/local is present. LP: #456917.
  * python3.1-doc: Fix searching in local documentation. LP: #456025.

 -- Matthias Klose <email address hidden> Mon, 02 Nov 2009 12:38:24 +0100

Changed in python3.1 (Ubuntu):
status: New → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Is this fixed in lucid's python2.6?

Changed in python2.6 (Ubuntu):
assignee: nobody → Matthias Klose (doko)
Revision history for this message
Mary Gardiner (puzzlement) wrote : Re: [Bug 456025] Please test proposed package

The fix does not seem to me to have worked (python2.6, karmic).

file:///usr/share/doc/python/html/search.html contains the following:

<script type="text/javascript" src="_static/jquery.js"></script>

But this is a symlink:

$ ls -l /usr/share/doc/python/html/_static/jquery.js
lrwxrwxrwx 1 root root 39 2009-11-04 11:37 /usr/share/doc/python/html/_static/jquery.js -> ../../../../javascript/jquery/jquery.js

The target of that symlink does not exist:

$ ls -l /usr/share/jquery.js
ls: cannot access /usr/share/jquery.js: No such file or directory

And in any case, it seems like /usr/share would be an odd destination for it.

Package versions:

python2.6-doc 2.6.4-0ubuntu2
python-doc 2.6.4-0ubuntu1

Revision history for this message
Douglas Bagnall (douglasbagnall) wrote :

Mary, I think you misread the symlink:

/usr/share/doc/python/html/_static/jquery.js -> ../../../../javascript/jquery/jquery.js

It is /usr/share/*javascript*/*jquery*/jquery.js,
not /usr/share/jquery.js

But are you saying it doesn't work in practice? If jquery.js isn't there, that would probably be the fault of the libjs-jquery package.

Revision history for this message
Mary Gardiner (puzzlement) wrote : Re: [Bug 456025] Re: Local documentation searching does not work due to typo in JS link

On Wed, Nov 04, 2009, Douglas Bagnall wrote:
> But are you saying it doesn't work in practice? If jquery.js isn't
> there, that would probably be the fault of the libjs-jquery package.

Actually it seems in order:

$ pwd
/usr/share/doc/python/html/_static

$ ls -l ../../../../javascript/jquery/jquery.js
-rw-r--r-- 1 root root 120763 2009-02-20 09:38 ../../../../javascript/jquery/jquery.js

And searching from file:///usr/share/doc/python/html/search.html now works.

I'm not sure what I was testing: possibly an incorrectly reloaded page in Firefox.

So: works for me now.

Revision history for this message
Martin Pitt (pitti) wrote :

I also confirm that the search box now works fine.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python2.6 - 2.6.4-0ubuntu2

---------------
python2.6 (2.6.4-0ubuntu2) karmic-proposed; urgency=low

  * python2.6-doc: Fix searching in local documentation. LP: #456025.

 -- Matthias Klose <email address hidden> Mon, 02 Nov 2009 11:44:54 +0100

Changed in python2.6 (Ubuntu Karmic):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Please fix in lucid's python2.6 as well.

Changed in python2.6 (Ubuntu Lucid):
milestone: none → lucid-alpha-1
Revision history for this message
Martin Pitt (pitti) wrote :

3.1 still needs to be tested.

tags: added: verification-needed
removed: verification-done
Revision history for this message
Matthias Klose (doko) wrote :

checked python3.1-doc in -proposed, already fixed in lucid.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python3.1 - 3.1.1-0ubuntu5

---------------
python3.1 (3.1.1-0ubuntu5) karmic-proposed; urgency=low

  * distutils install: Don't install into /usr/local/local, if option
    --prefix=/usr/local is present. LP: #456917.
  * python3.1-doc: Fix searching in local documentation. LP: #456025.

 -- Matthias Klose <email address hidden> Mon, 02 Nov 2009 12:38:24 +0100

Changed in python3.1 (Ubuntu Karmic):
status: Fix Committed → Fix Released
Steve Langasek (vorlon)
Changed in python2.6 (Ubuntu Lucid):
milestone: lucid-alpha-1 → lucid-alpha-2
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python2.6 - 2.6.4-4ubuntu1

---------------
python2.6 (2.6.4-4ubuntu1) lucid; urgency=low

  * Update to 20100122, taken from the 2.6 release branch.
    - Fix DoS via XML document with malformed UTF-8 sequences (CVE_2009_3560).
      Closes: #566233.
  * python2.6-doc: Fix searching in local documentation. LP: #456025.
  * Update locale module from the trunk. LP: #223281.
  * Merge with Debian (2.6.4-4).

python2.6 (2.6.4-4) unstable; urgency=low

  * Update to 20100122, taken from the 2.6 release branch.
    - Fix DoS via XML document with malformed UTF-8 sequences (CVE_2009_3560).
      Closes: #566233.
  * Hurd fixes (Pino Toscano). Closes: #565693:
    - hurd-broken-poll.dpatch: ported from 2.5.
    - hurd-disable-nonworking-constants.dpatch: disable a few constants from
      the public API whose C counterparts are not implemented, so using them
      either always blocks or always fails (caused issues in the test suite).
    - Exclude the profiled build for hurd.
    - Disable four blocking tests from the test suite.

python2.6 (2.6.4-3) unstable; urgency=low

  * Disable the profiled build on s390, mips, mipsel.
  * Fix symbol files for kfreebsd-amd64 and sparc64.

python2.6 (2.6.4-2) unstable; urgency=low

  * Update to 20100116, taken from the 2.6 release branch.
  * Fix bashism in makesetup shell script. Closes: #530170, #530171.
  * Fix build issues on avr (Bradley Smith). Closes: #528439.
    - Configure --without-ffi.
    - Don't run lengthly tests.
  * locale.py: Update locale aliases from the 2.7 branch.
 -- Matthias Klose <email address hidden> Fri, 22 Jan 2010 11:37:29 +0100

Changed in python2.6 (Ubuntu Lucid):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.