typeface.js

Selectable text visible sometimes

Bug #454997 reported by Fabien Ménager
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
typeface.js
Fix Released
Undecided
Unassigned

Bug Description

A few bugs reported in the forums a related to "duplicate text" which is in fact the selectable HTML text not hidden : http://typeface.neocracy.org/forum/topic.html?id=262
This seems to be fixed by adding "!important" to the color rule on line 758 : http://bazaar.launchpad.net/~davidchester/typeface.js/trunk/annotate/head%3A/js/typeface.js#L758

The CSS rules are not inserted if the page hasn't any stylesheet. In this case, we should maybe create one like it is for IE.

Revision history for this message
markuspxpx (markus-globo) wrote :

Solution:

put the CSS tag before the Scripts tags, like this:

  <link rel="stylesheet" type="text/css" href="style.css" />
  <title>Yout title</title>
  <script type="text/javascript" src="typeface-0.13.js"></script>
  <script type="text/javascript" src="helvetiker_regular.typeface.js"></script>

Revision history for this message
Fabien Ménager (fabien-menager) wrote :

I made a patch that solves this probleme and the bug reported by Giacecco here : http://typeface.neocracy.org/forum/topic.html?id=262

David Chester (davidchester)
Changed in typeface.js:
status: New → Confirmed
Revision history for this message
David Chester (davidchester) wrote :

Fabien, that patch looks good. I'd like to test a bit more, and then I'll go ahead and commit. Thanks!

Revision history for this message
David Chester (davidchester) wrote :

This patch is checked in.

Changed in typeface.js:
status: Confirmed → Fix Committed
David Chester (davidchester)
Changed in typeface.js:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.