LaunchpadForm should let you specify if multiply-supplied fields are OK or not

On Wed, Oct 14, 2009 at 04:51:59PM -0000, Julian Edwards wrote:
> Public bug reported:
>
> If someone specifies a GET request like this (possibly by URL hacking ):
>
> ?name_filter=blah&name_filter=wheee
>
> then retrieving the field from the form with code like this:
>
> self.request.get('name_filter')
>
> will return a list instead of an expected string. There should be a
> more generic way to say whether this is acceptable to the form, and
> gracefully reject such requests if not.

You mean something like self.request.form_ng.getOne('name_filter'),
which raises UnexpectedFormData if there is more than one value?

    subscribe bjornt
    status incomplete

What happens to the page when UFD is raised?

On Thu, Oct 15, 2009 at 08:47:56AM -0000, Julian Edwards wrote:
> What happens to the page when UFD is raised?

Well, that's a different issue. At the moment I think a rather ugly
error page is presented to the user. We should probably improve on that,
but not limit it to LaunchpadForm.

Okay.

The thing that triggered me to file this bug (after talking to Gary) is the
+ppas search form. It's a regular LaunchpadView, not a LaunchpadFormView.
I'm not sure it makes sense to have a search form as LFV but I don't have much
experience in doing these so I'd be happy to convert it if that's what is
normally done. But it would mean making an interface for a non-model object
right?

On Thu, Oct 15, 2009 at 09:23:05AM -0000, Julian Edwards wrote:
> Okay.
>
> The thing that triggered me to file this bug (after talking to Gary) is the
> +ppas search form. It's a regular LaunchpadView, not a LaunchpadFormView.
> I'm not sure it makes sense to have a search form as LFV but I don't have much
> experience in doing these so I'd be happy to convert it if that's what is
> normally done. But it would mean making an interface for a non-model object
> right?

It certainly does make sense to use LFV for a search page, but you don't
need to convert it. You can use self.request.form_ng.getOne() in any
view.

But yes, if you do want to convert the view, the easiest way is to
create an interface for the view. But it's also possible to create the
fields in the view itself.

Thanks for explaining Bjorn, I think this bug is invalid.