"Login" button is smaller than the "Cancel" button in the GDM theme

Bug #444421 reported by Mat Tomaszewski
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
human-theme
Fix Released
Undecided
Unassigned
gdm (Ubuntu)
Fix Released
Low
Unassigned
Nominated for Karmic by Mat Tomaszewski
human-theme (Ubuntu)
Fix Released
High
Kenneth Wimer
Nominated for Karmic by Mat Tomaszewski

Bug Description

Binary package hint: human-theme

The "login" button is visibly smaller than the "cancel" button on the login screen.

Attached is the approved design as a reference.

Revision history for this message
Mat Tomaszewski (mat.t.) wrote :
Changed in human-theme (Ubuntu):
status: New → Confirmed
Revision history for this message
Mat Tomaszewski (mat.t.) wrote :

This is a really weird bug, looks like the size of the "Login" button is defined independently of other buttons. The problem does not seem to occur anywhere else.

Does anyone have any ideas?

Changed in human-theme (Ubuntu):
assignee: nobody → Kenneth Wimer (kwwii)
Mat Tomaszewski (mat.t.)
description: updated
summary: - "Login" button is different than the "Cancel" button in the GDM theme
+ "Login" button is smaller than the "Cancel" button in the GDM theme
Mat Tomaszewski (mat.t.)
Changed in gdm (Ubuntu):
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

The issue appears to be in the theming.
"Cancel" is a stock button and is not behaving as the non-stock "Log In"

Revision history for this message
Robert Ancell (robert-ancell) wrote :

The lines that are causing the difference in size are in /usr/share/themes/HumanLogin/gtk-2.0/gtkrc:
  GtkButton::default_border = { 3, 3, 3, 3 }
  GtkButton::default_outside_border = { 3, 3, 3, 3 }

These set the border for buttons that can be the default selection - should these be replaced with inner_border if the idea is just to make the buttons bigger?

Changed in gdm (Ubuntu):
assignee: Robert Ancell (robert-ancell) → nobody
status: New → Incomplete
Revision history for this message
Mat Tomaszewski (mat.t.) wrote :

@Robert Ancell

Thanks for having a look at this. Suggested solution would be to drop the non-stock button for login and use a stock button (without the icon) instead. Would you say that's feasible?

Revision history for this message
Mat Tomaszewski (mat.t.) wrote :

@ kwwii

Any thoughts on this?

Changed in gdm (Ubuntu):
importance: Undecided → Low
Revision history for this message
Kenneth Wimer (kwwii) wrote :

We should change whatever we need to to fix this. I tried to fix it already but couldn't find any industrial theme which didn't have this problem.

Revision history for this message
Kenneth Wimer (kwwii) wrote :

After testing, Roberts suggestion proves to fix the problem (yeah!). Changed in the current lp:human-theme

Changed in human-theme (Ubuntu):
status: Confirmed → Fix Committed
importance: Undecided → High
Revision history for this message
Mat Tomaszewski (mat.t.) wrote : Re: [Bug 444421] Re: "Login" button is smaller than the "Cancel" button in the GDM theme

Kenneth Wimer wrote:
> After testing, Roberts suggestion proves to fix the problem (yeah!).
> Changed in the current lp:human-theme
>
>
Woo-hoo!

Nice work kwwii & thanks @Robert Ancell!

Revision history for this message
James Schriver (dashua) wrote :

I added an updated branch that has the button style, bg entry and glow as the original mock up. Please let me know if this is what was planned as I can tweak the theme some more? More glow can be easily added to the buttons if needed. Cancel and login buttons are the same as in the mock up with the cancel having an insensitive look.

bzr branch lp:~dashua/human-theme/humantheme

Regards,

dashua

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package human-theme - 0.37

---------------
human-theme (0.37) karmic; urgency=low

  * Changed button border values on HumanLogin gtkrc to fix LP: #444421
  * Added icons for shutdown pop-up at 48x48

 -- Kenneth Wimer <email address hidden> Mon, 12 Oct 2009 14:52:13 +0200

Changed in human-theme (Ubuntu):
status: Fix Committed → Fix Released
Changed in gdm (Ubuntu):
status: Incomplete → Fix Released
Changed in human-theme:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.