dirstate cannot handle versioned files that become fifo's.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Robert Collins | ||
2.0 |
Fix Released
|
Medium
|
Robert Collins |
Bug Description
I did cd /etc; bzr init; bzr add *; bzr ci -m initial several days ago.
Today I did an bzr diff /etc and it gave me:
# bzr diff /etc/
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return the_callable(*args, **kwargs)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
result = func(*args, **kwargs)
File "/usr/lib/
extra_
File "/usr/lib/
return differ.
File "/usr/lib/
return self._show_
File "/usr/lib/
executable) in sorted(iterator, key=changes_key):
File "_dirstate_
File "_dirstate_
File "_dirstate_
File "_dirstate_
Exception: unknown kind fifo
bzr 1.18.1 on python 2.6 (linux2)
arguments: ['/usr/bin/bzr', 'diff', '/etc/']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'de_DE.UTF-8'
plugins:
launchpad /usr/lib/
netrc_
qbzr /usr/lib/
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
# bzr version
Bazaar (bzr) 1.18.1
Python interpreter: /usr/bin/python 2.6
Python standard library: /usr/lib/python2.6
bzrlib: /usr/lib/
Bazaar configuration: /root/.bazaar
Bazaar log file: /root/.bzr.log
Copyright 2005, 2006, 2007, 2008, 2009 Canonical Ltd.
http://
bzr comes with ABSOLUTELY NO WARRANTY. bzr is free software, and
you may use, modify and redistribute it under the terms of the GNU
General Public License version 2 or later.
Related branches
- John A Meinel: Approve
- Vincent Ladeuil: Approve
-
Diff: 101 lines5 files modifiedNEWS (+3/-0)
bzrlib/_dirstate_helpers_pyx.pyx (+3/-1)
bzrlib/dirstate.py (+3/-1)
bzrlib/inventory.py (+1/-1)
bzrlib/tests/per_intertree/test_compare.py (+34/-0)
tags: | added: dirstate |
Changed in bzr: | |
status: | Confirmed → Fix Committed |
assignee: | nobody → Robert Collins (lifeless) |
Changed in bzr: | |
status: | Fix Committed → Fix Released |
Changed in bzr: | |
milestone: | none → 2.1.0b1 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Felix Möller wrote: Exception: unknown kind fifo python2. 6/site- packages/ bzrlib/ commands. py", line 835, in exception_ to_return_ code python2. 6/site- packages/ bzrlib/ commands. py", line 1030, in run_bzr python2. 6/site- packages/ bzrlib/ commands. py", line 647, in run_argv_aliases **all_cmd_ args) python2. 6/site- packages/ bzrlib/ commands. py", line 1045, in ignore_pipe python2. 6/site- packages/ bzrlib/ builtins. py", line 1913, in run extra_trees, using=using) python2. 6/site- packages/ bzrlib/ diff.py" , line 432, in show_diff_trees show_diff( specific_ files, extra_trees) python2. 6/site- packages/ bzrlib/ diff.py" , line 839, in show_diff diff(specific_ files, extra_trees) python2. 6/site- packages/ bzrlib/ diff.py" , line 862, in _show_diff helpers_ pyx.pyx" , line 1349, in _dirstate_ helpers_ pyx.ProcessEntr yC.__next_ _ helpers_ pyx.pyx" , line 1614, in _dirstate_ helpers_ pyx.ProcessEntr yC._iter_ next helpers_ pyx.pyx" , line 1704, in _dirstate_ helpers_ pyx.ProcessEntr yC._loop_ one_block helpers_ pyx.pyx" , line 1175, in _dirstate_ helpers_ pyx.ProcessEntr yC._process_ entry
> Public bug reported:
>
> I did cd /etc; bzr init; bzr add *; bzr ci -m initial several days ago.
>
> Today I did an bzr diff /etc and it gave me:
> # bzr diff /etc/
> bzr: ERROR: exceptions.
>
> Traceback (most recent call last):
> File "/usr/lib/
> return the_callable(*args, **kwargs)
> File "/usr/lib/
> ret = run(*run_argv)
> File "/usr/lib/
> return self.run(
> File "/usr/lib/
> result = func(*args, **kwargs)
> File "/usr/lib/
> extra_trees=
> File "/usr/lib/
> return differ.
> File "/usr/lib/
> return self._show_
> File "/usr/lib/
> executable) in sorted(iterator, key=changes_key):
> File "_dirstate_
> File "_dirstate_
> File "_dirstate_
> File "_dirstate_
> Exception: unknown kind fifo
>
Interesting. My best guess is that you added something that used to be a
file, and has since turned into a FIFO. (We automatically skip over FIFO
during add, but something at a given path can always turn into something
else.)
Thanks for the report.
status confirmed
importance high
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
CHWwACgkQJdeBCY SNAAPdVgCYlb/ q2xcLH25dtOvNR8 yELh8l X1KY/WOnKjcRwop jQsaU=
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEUEARECAAYFAkr
RwCfTOs0br/
=pR4t
-----END PGP SIGNATURE-----