SchoolTool Gradebook

Ability to hide worksheets

Bug #427494 reported by Alan Elkner
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
SchoolTool Gradebook
Fix Released
Medium
Alan Elkner
SchoolTool Gradebook 0.5.2 "xmas"

Bug Description

In the activities view of a section, we need to reintroduce the checkboxes next to the worksheets, but this time, the button at the bottom should say 'Hide' rather than 'Delete'. Any worksheet that is checked when the Hide button is pushed will have the hide attribute set to True.

ALL code that loops though worksheets needs to be changed to use a new property of the Activities object called 'worksheets' which will only return those worksheets that are not hidden. This change will need to made in several places, so be careful to find them all.

See original description
Alan Elkner (aelkner)
description: updated
Changed in schooltool:
assignee: nobody → Alan Elkner (aelkner)
importance: Undecided → Medium
milestone: none → karmic
status: New → Triaged
Alan Elkner (aelkner)
Changed in schooltool:
status: Triaged → Fix Committed
Gediminas Paulauskas (menesis)
affects: schooltool → schooltool.gradebook
Changed in schooltool.gradebook:
milestone: lucid → none
milestone: none → 0.5.2
Revision history for this message
Gediminas Paulauskas (menesis) wrote :

Sorry, if I hide a worksheet I get an error when I return to the Gradebook:

File "/home/menesis/src/schooltool/trunk/build/schooltool.gradebook/src/schooltool/gradebook/browser/gradebook.py", line 539, in table
  value = self.getStudentActivityValue(student, activity)
File "/home/menesis/src/schooltool/trunk/build/schooltool.gradebook/src/schooltool/gradebook/browser/gradebook.py", line 515, in getStudentActivityValue
  value, ss = gradebook.getEvaluation(student, activity)
File "/home/menesis/src/schooltool/trunk/build/schooltool.gradebook/src/schooltool/gradebook/gradebook.py", line 166, in getEvaluation
  activity = self._checkActivity(activity)
File "/home/menesis/src/schooltool/trunk/build/schooltool.gradebook/src/schooltool/gradebook/gradebook.py", line 153, in _checkActivity
  '%r is not part of this section.' %activity.title)

There was only one worksheet.

Changed in schooltool.gradebook:
status: Fix Committed → In Progress
Revision history for this message
Alan Elkner (aelkner) wrote :

Good catch. I needed to add protection against the case where the user's current worksheet is hidden.

Changed in schooltool.gradebook:
status: In Progress → Fix Committed
Gediminas Paulauskas (menesis)
Changed in schooltool.gradebook:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.