email command strings should be case insensitive
Bug #425934 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Ivo Kracht | ||
Bug Description
Could be a usability issue in code email support:
> > Requesting my required second review.
> >
> > John: Launchpad did not seem to notice you approve directive.
>
> Very strange. It obviously got the message, as it has it on the
proposal page.
> And I can't be much clearer than Review: approve...
Review != review and the interface is case sensitive.
Related branches
lp:~ivo-kracht/launchpad/bug-425934
- Raphaël Badin (community): Approve
- Francesco Banconi (community): Approve (code*)
- Ivo Kracht (community): Needs Resubmitting
- Benji York (community): Approve (code)
-
Diff: 246 lines (+83/-20)7 files modifiedlib/lp/bugs/mail/commands.py (+2/-0)
lib/lp/bugs/mail/handler.py (+4/-3)
lib/lp/code/mail/codehandler.py (+1/-1)
lib/lp/services/mail/commands.py (+7/-2)
lib/lp/services/mail/helpers.py (+9/-2)
lib/lp/services/mail/tests/test_commands.py (+34/-1)
lib/lp/services/mail/tests/test_helpers.py (+26/-11)
Revision history for this message
| Tim Penhey (thumper) wrote Re: [Bug 425934] [NEW] how many spaces does a leading space need? | #1 |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
Revision history for this message
| Paul Hummer (rockstar) wrote Re: how many spaces does a leading space need? | #3 |
| Changed in launchpad-code: | |
| status: | New → Incomplete |
Revision history for this message
| Robert Collins (lifeless) wrote Re: [Bug 425934] Re: how many spaces does a leading space need? | #4 |
| Changed in launchpad-code: | |
| status: | Incomplete → New |
Revision history for this message
| Tim Penhey (thumper) wrote | #5 |
Revision history for this message
| Tim Penhey (thumper) wrote Re: how many spaces does a leading space need? | #6 |
Revision history for this message
| Tim Penhey (thumper) wrote | #7 |
| Changed in launchpad-code: | |
| assignee: | nobody → Björn Tillenius (bjornt) |
| status: | New → Incomplete |
Revision history for this message
| Björn Tillenius (bjornt) wrote | #8 |
| affects: | launchpad-code → launchpad-foundations |
| Changed in launchpad-foundations: | |
| assignee: | Björn Tillenius (bjornt) → nobody |
| importance: | Undecided → Medium |
| status: | Incomplete → Triaged |
| tags: | added: email |
| summary: |
- how many spaces does a leading space need? + email command strings should be case insensitive |
| description: | updated |
| Changed in launchpad: | |
| importance: | Medium → High |
| tags: | removed: lp-foundations |
| tags: | added: easy |
| Changed in launchpad: | |
| assignee: | nobody → Ivo Kracht (ivo-kracht) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #9 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
Revision history for this message
| William Grant (wgrant) wrote | #10 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
On Tue, 08 Sep 2009 08:46:06 Robert Collins wrote:
> Public bug reported:
>
> affects launchpad-code
> done
>
> Could be a usability issue in code email support:
All email commands are lower case, so
"Review" doesn't match "review"
This is the same as the bugs interface.