Ubuntu
pkgbinarymangler package

Merge/Remove .pc/ files into the main translation

Bug #410658 reported by Milo Casagrande
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Translations
Fix Released
Wishlist
Unassigned
pkgbinarymangler (Ubuntu)
Fix Released
High
Martin Pitt

Bug Description

Binary package hint: gthumb

The current version of the package has a hidden directory with po files in it. The tree is like this:

.pc/05-fix_locales.patch
.pc/06-add_keybinding_DoNotSave.patch

A quick look at a couple of those files (done with diff), looks like the .pc files are older than the one in the normal po/ directory.

As discussed in the ubuntu-translations-list [1], this might be confusing to translators, and we agreed on merging all translations in one single template as most of the other packages do.

Seb mentioned this rule in the debian/rules file:

include /usr/share/gnome-pkg-tools/1/rules/patch-translations.mk

so the fix might be as simple as removing it.

[1] https://lists.launchpad.net/ubuntu-translations-coordinators/msg00099.html

Tags: import
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I can't find that folder in the current source tarball. The folder ".pc" is a temporary folder used by the Quilt patch system when editing patches in the source folder, and isn't really related to translations. What is the issue here?

Changed in gthumb (Ubuntu):
status: New → Incomplete
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Right, ok, the .pc/ folder will exist during build time when the translations are stripped from the package, as the patches will be applied for the build. There's not anything we can do about that. This folder contains the original version of any source files touched by a patch so that the original versions can be restored when the patch is removed. If a patch updates a pot file then the original pot file will appear solmewhere in the .pc/ folder - that's just the nature of how the Quilt patch system works.

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Perhaps this is a pkgbinarymangler bug instead? pkgstriptranslations should ignore the files in .pc/

Revision history for this message
Milo Casagrande (milo) wrote :

The "problem" is that those files get stuck in the translations import queue, 'cause they don't have a POT template files. But even if they had one they will probably get stuck since the source path is not know to Launchapd.

If those files are there only as a "backup" thing, we can block them from being imported into Rosetta (I'm talking about only .po files), and they won't be imported anymore. If a completely new translation is added and "patched", it will show up since it will be new to Rosetta, though. That's why it should be better to remove that directory from the translations traballs.

Do you assure me it's not possible to remove that directory?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Milo - it's not possible to remove this folder, as it doesn't exist in the source tarball. It is created dynamically at build time by the quilt patch system, when the patch-set is applied. I really don't think there's anything that can be done in gthumb to stop that.

However, pkgstriptranslations could possibly be modified to ignore this folder, and not copy the "translations" from there. Assigning this to pkgbinarymangler for now.

affects: gthumb (Ubuntu) → pkgbinarymangler (Ubuntu)
Changed in pkgbinarymangler (Ubuntu):
importance: Undecided → Low
status: Incomplete → Confirmed
importance: Low → Wishlist
Adi Roiban (adiroiban)
tags: added: import-queue
Changed in ubuntu-translations:
status: New → Confirmed
importance: Undecided → Wishlist
Adi Roiban (adiroiban)
tags: added: import
removed: import-queue
Martin Pitt (pitti)
Changed in pkgbinarymangler (Ubuntu):
status: Confirmed → Fix Committed
assignee: nobody → Martin Pitt (pitti)
importance: Wishlist → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 64

---------------
pkgbinarymangler (64) lucid; urgency=low

  * pkgstriptranslations: Do not copy .pc/* into the translation tarball.
    (LP: #410658)
 -- Martin Pitt <email address hidden> Sun, 15 Nov 2009 05:52:17 -0600

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
Martin Pitt (pitti)
Changed in ubuntu-translations:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.