bp.fastimport.commands.CommitCommand.__init__'s file_iter argument is passed *AND* treated inconsistantly
Bug #406097 reported by
Samuel Bronson
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| python-fastimport |
Fix Released
|
Low
|
Jelmer Vernooij | ||
Bug Description
It seems that half the tests pass a callable returning an iterable and half of them pass an iterator.
It also seems that CommitCommand.
Running "bzr fast-import foo.txt" results in callables being passed, some I'm going to assume that was what was intended unless you tell me otherwise.
Related branches
Revision history for this message
| Ian Clatworthy (ian-clatworthy) wrote | #1 |
| Changed in bzr-fastimport: | |
| importance: | Undecided → Low |
| status: | New → Triaged |
| affects: | bzr-fastimport → python-fastimport |
| Changed in python-fastimport: | |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| status: | Triaged → Fix Committed |
| Changed in python-fastimport: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It's meant to be an iterable, not a callable. I've fixed dump_str() in rev 194 accordingly.
All the tests still pass and in a quick inspection, I couldn't see where callables were being passed. Can you point to where's that's being done please?