Bazaar

bzr 1.17: _knit_load_data_pyx C-extension is not imported

Bug #405653 reported by Alexander Belchenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Unassigned
1.17
Won't Fix
High
Andrew Bennetts
Launchpad itself
Fix Released
Medium
Aaron Bentley

Bug Description

While building my own custom installer for bzr.exe 1.17 I found that _knit_load_data_pyx C-extension
actually is not imported at all in bzrlib. Instead there is still attempts to import old name
"_knit_load_data_c" extension.

_knit_load_data_c was renamed to _knit_load_data_pyx by Vincent in bzr.dev revno 4472 but Vincent
did not update all imports. At least not in 1.17.

I don't know is it critical for performance (I suppose -- yes), but it does not sound right for me
anyway.

Tags: lp-code

Related branches

lp:~spiv/bzr/c-extension-regression
bzr-core: Pending requested
Diff: 68 lines
Revision history for this message
Alexander Belchenko (bialix) wrote :

Still the same in bzr 1.18dev (bzr.dev revno 4573)

Changed in bzr:
status: New → Confirmed
Revision history for this message
Andrew Bennetts (spiv) wrote :

You're right, this is critical for performance, so I'm setting the Importance accordingly. We should issue a 1.17.1 with a fix for this, I think.

Changed in bzr:
importance: Undecided → Critical
Revision history for this message
Andrew Bennetts (spiv) wrote :

I've submitted a fix to PQM for bzr.dev, but we should put the fix on the 1.17 branch too.

Changed in bzr:
status: Confirmed → Fix Committed
Revision history for this message
Andrew Bennetts (spiv) wrote :

Fixed in bzr.dev.

Changed in bzr:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 405653] Re: bzr 1.17: _knit_load_data_pyx C-extension is not imported

See also bug 406113 regarding checking for them.

Revision history for this message
Andrew Bennetts (spiv) wrote :

Incidentally, John points out that this extension is only used for reading .kndx files, so it should only affect old knit format repositories.

Anyway, there is a branch with this fix cherrypicked at lp:~spiv/bzr/1.17 if we do want to make a 1.17.1 release.

Revision history for this message
Tim Penhey (thumper) wrote :

Lets get bzr 1.18 on LP.

Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
importance: Undecided → Medium
status: New → Confirmed
Jonathan Lange (jml)
Changed in launchpad-code:
status: Confirmed → Triaged
Aaron Bentley (abentley)
Changed in launchpad-code:
status: Triaged → Fix Released
Revision history for this message
Martin Pool (mbp) wrote :

It looks like this didn't get into a 1.17 series release, and it probably doesn't matter because that series is no longer supported.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.