sprite class bleeds extra images in tall elements
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs | ||
Bug Description
This is a similar issue to bug 389737, which was solved in some other manner. The vocabulary items in the picker widget can only display one line of text for the title and one line for the description. If the <li> gets any taller, the next image in the sprite file starts to be displayed.
This is a problem because there is no way to clip the background image except by sizing its container. There are two potential solutions. The picker can be restructured to add the css class to an element inside the <li>, which would contain the background image separately from the text elements. The sprite image file could have the space between images increased significantly, although I don't know whether this would increase the size of the image file or the image compression would handle that.
Related branches
- Brad Crittenden (community): Approve (code)
-
Diff: 1796 lines (+1493/-146)12 files modifiedMakefile (+11/-2)
buildout-templates/bin/combine-css.in (+2/-2)
buildout-templates/bin/sprite-util.in (+43/-0)
lib/canonical/launchpad/browser/vocabulary.py (+1/-1)
lib/canonical/launchpad/icing/icon-sprites.positioning (+472/-0)
lib/canonical/launchpad/icing/style-3-0.css.in (+491/-132)
lib/lp/app/browser/tests/base-layout.txt (+7/-8)
lib/lp/app/templates/base-layout-macros.pt (+1/-1)
lib/lp/services/doc/sprites.txt (+185/-0)
lib/lp/services/spriteutils.py (+243/-0)
lib/lp/services/tests/test_doc.py (+17/-0)
lib/lp/services/tests/testfiles/template.css (+20/-0)
| tags: | added: tech-debt |
| Данило Шеган (danilo) wrote | #1 |
| affects: | launchpad → launchpad-foundations |
| Changed in launchpad-foundations: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: post-3-ui-cleanup sprite |
| Edwin Grubbs (edwin-grubbs) wrote Re: [Bug 405476] Re: sprite class bleeds extra images in tall elements | #2 |
| tags: |
added: css removed: sprite |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Martin Albisetti (beuno) |
| Martin Albisetti (beuno) wrote | #3 |
| Changed in launchpad-foundations: | |
| assignee: | Martin Albisetti (beuno) → nobody |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #4 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| tags: |
added: qa-ok removed: qa-needstesting |
It would be useful to try playing with background-clip (see http://