Show comments from superseded proposals
Bug #400032 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Aaron Bentley | ||
Bug Description
the comments from superseded proposal should be included on the page for the proposal that supersedes them, in a way that is visually distinct, with backlinks to the superseded version.
They need a footer with a hyperlink to the superseded proposal, and a background colour that is different. And no reply link.
Related branches
lp:~abentley/launchpad/superseded-comments
- Tim Penhey (community): Approve
- Paul Hummer (community): Approve (ui)
-
Diff: 179 lines (+67/-8)8 files modifiedlib/canonical/launchpad/icing/style.css (+1/-0)
lib/lp/code/browser/branchmergeproposal.py (+8/-4)
lib/lp/code/browser/codereviewcomment.py (+9/-1)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+15/-0)
lib/lp/code/stories/branches/xx-code-review-comments.txt (+24/-0)
lib/lp/code/templates/codereviewcomment-header.pt (+5/-1)
lib/lp/services/comments/interfaces/conversation.py (+4/-1)
lib/lp/services/comments/templates/comment.pt (+1/-1)
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Aaron Bentley (abentley) |
| milestone: | none → 10.02 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
