Automatic play -> Auto drop setting forgotten

Bug #39975 reported by Tomasz Dominikowski
8
Affects Status Importance Assigned to Milestone
pysol (Debian)
Fix Released
Unknown
pysol (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Pysol resets this setting to false every time it starts. It's annoying having to to switch it on every time.

Related branches

Changed in pysol:
status: Unconfirmed → Confirmed
Revision history for this message
Scott Kitterman (kitterman) wrote :

Confirmed to still be an issue in Feisty. Note that upstream development of pysol has stopped and so the odds of a fix for this are low.

Changed in pysol:
status: Unknown → Unconfirmed
Changed in pysol:
assignee: nobody → edoardo-batini
Revision history for this message
Edoardo Batini (edoardo-batini) wrote : pysol reset almost every setting at restart.

It seems pysol reset almost every setting at restart.

These are all the settings that retain user choices:
cardset
card background
table tile
animations
toolbar options
hint options
demo options: only delay time retains choices

Revision history for this message
Edoardo Batini (edoardo-batini) wrote :

class Option in app.py uses int values 0, 1 to set user preferences.
When user change a preference in a checkbox that value was changed to boolean True or False.
That's why only two values options were giving problems.
Hacked to convert back each boolean to 0 or 1 from custom options file so that Pysol accept that values.

Problem seem to be solved. Some testing is needed to be sure this change doesn't create problems with games that have forced options.

Changed in pysol:
status: Confirmed → In Progress
Revision history for this message
Scott Kitterman (kitterman) wrote :

I got dpatch working (this patch was fine). Since you've apparently gone to bed, I went ahead and debdiffed the results of what you did and what I did and attached it here for upload.

Changed in pysol:
assignee: edoardo-batini → nobody
status: In Progress → Confirmed
Revision history for this message
Gauvain Pocentek (gpocentek) wrote :

Package uploaded. Thanks for your work!

Changed in pysol:
status: Confirmed → Fix Committed
Changed in pysol:
status: Fix Committed → Fix Released
Changed in pysol (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.