apport-cli -c incorrectly reprocesses hooks

Bug #394497 reported by Kees Cook
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Fix Released
Medium
Martin Pitt

Bug Description

Binary package hint: apport

apport seems to re-collect problem information instead of loading it from the crash file in -c. In my case, I was reporting a X bug and needed to collect details during a broken session ("save for later") and then upload it during a working session. However, -c seems to have re-collected all the logs, etc (see bug 394492).

I would have expected no "Collecting problem information" phase, and a prompt, as seen with --file-bug so I could View the report before uploading it.

Perhaps there needs to be a --continue option instead of a --crash-file, since the "save for later" data is not strictly a crash file (it has already had collected information attached to it).

$ apport-cli -c ~/apport.JlWcWt.txt

*** Collecting problem information

The collected information can be sent to the developers to improve the
application. This might take a few minutes.
......

*** Uploading problem information

The collected information is being sent to the bug tracking system.
This might take a few minutes.

ProblemType: Bug
Architecture: amd64
Date: Wed Jul 1 14:50:06 2009
DistroRelease: Ubuntu 9.10
Package: apport 1.5-0ubuntu2
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.30-10.12-generic
SourcePackage: apport
Uname: Linux 2.6.30-10-generic x86_64

Revision history for this message
Kees Cook (kees) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

I agree, -c should check if the report already has a Package: field, and not re-collect information in this case.

Changed in apport (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

trunk r1504

Changed in apport (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 1.6-0ubuntu1

---------------
apport (1.6-0ubuntu1) karmic; urgency=low

  * New upstream release:
    - Add support for kernel crashes, thanks to Michael Vogt!
    - apport/ui.py, run_crash(): Do not re-collect information if we already
      have a Dependencies field. This happens when calling apport on an already
      pre-processed .crash file with -c. (LP: #394497)
    - apport/hookutils.py, pci_devices(): Deliver all matching devices, not
      just the last one. (LP: #398906)
    - hookutils.py, _get_module_license(): Return "invalid" if modinfo fails,
      so that they do not count as "free". (LP: #341720)
    - packaging-apt-dpkg.py: Support additional custom native origins in
      /etc/apport/native-origins.d/ . (LP: #386052)
    - packaging-apt-dpkg.py: Drop PPA origin hack, launchpad behaves properly
      now
    - apport-gtk: Avoid focus stealing when being called without arguments (i.
      e. auto-launched). LP: #396243)
    - apport-kde: Use standard gettext again
    - Fix handling of PC lacking disassembly due to invalid memory location.
  * debian/local/apport-collect: Tag bugs with "apport-collected" on success.
    (LP: #391392)

 -- Martin Pitt <email address hidden> Wed, 15 Jul 2009 18:02:59 +0200

Changed in apport (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.