unnecessary stacking upgrade warning with bzr.dev
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Andrew Bennetts |
Bug Description
affects bzr
importance high
status triaged
done
!bzr push bzr
+ssh://
Source branch format does not support stacking, using format:
Branch format 7
Using default stacking
branch /~testresources
lp-139738591703
Created new stacked branch referring
to /~testresources
:!bzr info -v
Standalone tree (format: 1.9-rich-root)
Location:
branch root: .
Format:
control: Meta directory format 1
working tree: Working tree format 4
branch: Branch format 7
repository: Packs 6 rich-root (uses btree indexes, requires bzr 1.9)
--
Related branches
- Robert Collins (community): Approve
- Diff: None lines
This is a regression in 1.16, I think.
It's a messy one, though. When RemoteBzrDirFor mat.initialize_ on_transport_ ex invokes require_stacking() it has no knowledge of the source format (despite the message it emits!), so it's difficult to fix.
My initial feeling is that initialize_ on_transport_ ex is the problem: it is half-way between a simple function and a comprehensive one. Specifically, it handles bzrdirs and repositories, but not branches. My suspicion is that the right fix will be to extend initialize_ on_transport_ ex (or make a new variant) that also initializes branches.