upstart

reboot: should imply --force during shutdown

Bug #388738 reported by Casey Dahlin on 2009-06-18

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
upstart	Fix Released	Medium	Scott James Remnant (Canonical)	upstart 0.6.0 "How appropriate, you fight like a cow"
0.3	Won't Fix	Medium	Unassigned
0.5	Won't Fix	Medium	Unassigned
Trunk	Won't Fix	Medium	Unassigned
upstart (Fedora)	Fix Released	Low	redhat-bugs #431107
upstart (Ubuntu)	Fix Released	Low	Unassigned

Bug Description

https://bugzilla.redhat.com/show_bug.cgi?id=431107 explains. When running halt/reboot while shutting down --force should be implicit. Patch should go to 0.3.11, I tagged for everything else since I'm not sure if this is still present.

See original description

Related branches

lp:~ubuntu-core-dev/upstart/ubuntu

lp:ubuntu/lucid/upstart

Revision history for this message

In Red Hat Bugzilla #431107, Bill (bill-redhat-bugs) wrote on 2008-01-31:

If you attempt to shutdown/reboot/halt, the halt script just ends up looping
endlessly.

initscripts-8.62-1

Revision history for this message

In Red Hat Bugzilla #431107, Casey (casey-redhat-bugs) wrote on 2008-02-11:

Have we decided if patching killall5 will work for this?

Revision history for this message

In Red Hat Bugzilla #431107, Bill (bill-redhat-bugs) wrote on 2008-02-14:

It doesn't loop any more, but it doesn't do the right thing either.

Revision history for this message

In Red Hat Bugzilla #431107, Bill (bill-redhat-bugs) wrote on 2008-02-15:

#10

This is an upstart bug, at least as far as SysV compatibility goes.

halt/reboot under SysV check the runlevel when they run - if it's 0 or 6
(reboot/halt), then 'force' is implied. upstart's versions don't have that code,
so they just call shutdown again, which starts the loop/hangs.

Patch attached momentarily.

Revision history for this message

In Red Hat Bugzilla #431107, Bill (bill-redhat-bugs) wrote on 2008-02-15:

#11

Created attachment 295051
check runlevel in halt/reboot, set --force accordingly

Revision history for this message

In Red Hat Bugzilla #431107, Casey (casey-redhat-bugs) wrote on 2008-02-16:

#12

Do we want to apply just this patch to upstart, or both this patch and the
no-kill-init sysv patch?

I'll roll this in to the rpm tonight. Scott, care to weigh in?

Revision history for this message

In Red Hat Bugzilla #431107, Scott (scott-redhat-bugs) wrote on 2008-02-16:

#13

That patch is definitely the right solution ;)

It didn't affect us because our sysv scripts called halt/reboot with --force anyway

Revision history for this message

In Red Hat Bugzilla #431107, Casey (casey-redhat-bugs) wrote on 2008-02-17:

#14

Well played then :) Rebuilt upstart package is in koji.

We still end up re-executing init on shutdown, but this no longer creates this
issue. I may open another bug about that but for now its no big deal.

Revision history for this message

Casey Dahlin (cjdahlin) wrote on 2009-06-18:

Fix for issue Edit (1.1 KiB, text/plain)

tags:

added: target-milestone-0.3
removed: target-release-0.3

Casey Dahlin (cjdahlin) on 2009-06-18

tags:	removed: target-milestone-0.3
description:	updated

Scott James Remnant (Canonical) (canonical-scott) on 2009-06-18

Changed in upstart (Ubuntu):
importance:	Undecided → Low
status:	New → Triaged

Bug Watch Updater (bug-watch-updater) on 2009-06-18

Changed in upstart (Fedora):
status:	Unknown → Fix Released

Revision history for this message

Scott James Remnant (Canonical) (canonical-scott) wrote on 2009-06-18:

This looks like basically the right approach to me, grab the RUNLEVEL environment variable, otherwise look in utmp.

It'd be nice to make that a bit more generic, I think runlevel and telinit need the same code for things?

Scott James Remnant (Canonical) (canonical-scott) on 2009-06-18

summary:

- halt on shutdown should imply --force
+ reboot/poweroff/halt during shutdown should imply --force

Scott James Remnant (Canonical) (canonical-scott) on 2009-06-18

summary:

- reboot/poweroff/halt during shutdown should imply --force
+ reboot: should imply --force during shutdown

Revision history for this message

Scott James Remnant (Canonical) (canonical-scott) wrote on 2009-07-08:

Won't fix this in 0.3 or 0.5, the fixed code has been committed (along with writing a shutdown wtmp record) to trunk.

Revision history for this message

Scott James Remnant (Canonical) (canonical-scott) wrote on 2009-07-09:

Preparing packages of Upstart 0.6.0 for karmic

Changed in upstart (Ubuntu):
status:	Triaged → In Progress

Scott James Remnant (Canonical) (canonical-scott) on 2009-07-09

Changed in upstart:
milestone:	none → 0.6.0

Revision history for this message

Scott James Remnant (Canonical) (canonical-scott) wrote on 2009-07-09:

Download full text (6.7 KiB)

This has been fixed in Upstart 0.6.0.

0.6.0 2009-07-09 "How appropriate, you fight like a cow"

* The licence for Upstart has been changed back to version 2 of the
GNU GPL.

* D-Bus 1.2.15 is now required, this is the current GIT HEAD
pending a 1.2.16 release.

* Configuration paths have changed. Global configuration now
resides in "/etc/init.conf" while jobs are now configured in
"/etc/init"

* Job configuration filenames must now end in ".conf"

* Default configuration files are now supplied in the "conf"
sub-directory of the source, and installed into "/etc/init".

   These match the Debian/Ubuntu sysvinit configuration so may
   require some tweaking for other distributions, but provide an
   excellent base.

The old example-jobs tarballs are deprecated.

* The D-Bus interface remains unstable, to reflect this the current
interface name has changed to "com.ubuntu.Upstart0_6" and the
name of the job and instance interfaces have changed to match.

* The "EmitEvent" D-Bus method gains a wait argument, when given
   as TRUE (the recommended setting) the method call will be blocked
   until all effects of the event have finished. When FALSE the
   method call will return once the event has been queued.

* The "Start", "Stop" and "Restart" D-Bus methods of jobs and
instances gain a similar wait argument.

* The Upstart D-Bus object now has "version" and "log_priority"
properties. The former is to obtain the version of the init daemon,
the latter allows you to obtain and change the logging priority.

* Job D-Bus objects now have "name", "description", "author" and
"version" properties to obtain the job name and the contents of
the equivalent job file fields for the others.

* Instance D-Bus objects now have "name", "goal", "state" and
"processes" properties to obtain the instance name, goal, state
and list of running processes and their pids respectively.

* The default D-Bus security policy now permits use of the "Get"
methods by all users, including obtaining values of properties.

* initctl has been rewritten with functionality more along the
   lines of Upstart 0.3.x than before; since many distributions are
   still shipping 0.3.x the summary of changes for the tool reflects
   both changes from 0.3.x and 0.5.x

* The global "-p"/"--pid" argument has been dropped, since
   communication is over D-Bus. New "--system" and "--dest" arguments
   have been added to force communication over the system bus, and
   specify the destination, instead of using the private socket (this
   is the default when run as non-root to permit "list" and "status"
   to work for ordinary users).

* The "-i"/"--id" and "--show-ids" options to commands have been
dropped since jobs no longer have ids.

* Since instances may now have names, these will be displayed in
   brackets after the job name when one is present. The output of
   the goal and state are now expressed as "start/running" instead
   of "(start) running" to disambiguate.

* initctl "start" and "stop" now only output the final state of
the job, not inte...

This has been fixed in Upstart 0.6.0.

0.6.0  2009-07-09  "How appropriate, you fight like a cow"

* The licence for Upstart has been changed back to version 2 of the
	  GNU GPL.

* D-Bus 1.2.15 is now required, this is the current GIT HEAD
	  pending a 1.2.16 release.

* Configuration paths have changed.  Global configuration now
	  resides in "/etc/init.conf" while jobs are now configured in
	  "/etc/init"

* Job configuration filenames must now end in ".conf"

* Default configuration files are now supplied in the "conf"
	  sub-directory of the source, and installed into "/etc/init".

These match the Debian/Ubuntu sysvinit configuration so may
	  require some tweaking for other distributions, but provide an
	  excellent base.

The old example-jobs tarballs are deprecated.

* The D-Bus interface remains unstable, to reflect this the current
	  interface name has changed to "com.ubuntu.Upstart0_6" and the
	  name of the job and instance interfaces have changed to match.

* The "EmitEvent" D-Bus method gains a wait argument, when given
	  as TRUE (the recommended setting) the method call will be blocked
	  until all effects of the event have finished.  When FALSE the
	  method call will return once the event has been queued.

* The "Start", "Stop" and "Restart" D-Bus methods of jobs and
	  instances gain a similar wait argument.

* The Upstart D-Bus object now has "version" and "log_priority"
	  properties.  The former is to obtain the version of the init daemon,
	  the latter allows you to obtain and change the logging priority.

* Job D-Bus objects now have "name", "description", "author" and
	  "version" properties to obtain the job name and the contents of
	  the equivalent job file fields for the others.

* Instance D-Bus objects now have "name", "goal", "state" and
	  "processes" properties to obtain the instance name, goal, state
	  and list of running processes and their pids respectively.

* The default D-Bus security policy now permits use of the "Get"
	  methods by all users, including obtaining values of properties.

* initctl has been rewritten with functionality more along the
	  lines of Upstart 0.3.x than before; since many distributions are
	  still shipping 0.3.x the summary of changes for the tool reflects
	  both changes from 0.3.x and 0.5.x

* The global "-p"/"--pid" argument has been dropped, since
	  communication is over D-Bus.  New "--system" and "--dest" arguments
	  have been added to force communication over the system bus, and
	  specify the destination, instead of using the private socket (this
	  is the default when run as non-root to permit "list" and "status"
	  to work for ordinary users).

* The "-i"/"--id" and "--show-ids" options to commands have been
	  dropped since jobs no longer have ids.

* Since instances may now have names, these will be displayed in
	  brackets after the job name when one is present.  The output of
	  the goal and state are now expressed as "start/running" instead
	  of "(start) running" to disambiguate.

* initctl "start" and "stop" now only output the final state of
	  the job, not intermediate states it passes through.  When called
	  with "--no-wait", the commands now output a status before
	  returning (which may not be the final status).

* initctl "start", "stop" and "status" now only accept a single
	  job name.  Further arguments are taken as KEY=VALUE environment
	  variables to pass to the job, replacing the previous "-e" option.

* There is a new initctl "restart" command, with matching
	  /sbin/restart symlink.  This is the atomic equivalent of calling
	  "stop" and "start" with the exception that a stopped job will
	  not be started again.

* In keeping with the newer instance model, instance jobs are now
	  output on separate lines with their full names rather than
	  indented under a "master" instance.

* initctl "status" will exit non-zero if the job name was not
	  found.  (Bug: #328323)

* initctl "status" now outputs information for multi-instance
	  jobs.  (Bug: #331407)

* initctl "list" no longer accepts a pattern, use grep.  Output
	  is no longer sorted.

* initctl "emit" no longer outputs changes that occur as a result
	  of the event.

* When initctl "emit" is called with "--no-wait", it will return
	  immediately.  (Bug: #324890)

* initctl "emit" now only accepts a single event name.  Further
	  arguments are taken as KEY=VALUE environment for the event,
	  replacing the previous "-e" option.

* initctl "jobs" and "events" have been dropped.

* initctl "log-priority" may be called without arguments, in
	  which case it will output the current priority.  (Bug: #280529)

* initctl "reload" has been renamed to "reload-configuration"
	  to avoid confusion with reloading a job's configuration.

* initctl(8) man page updated.  (Bug: #285753)

* runlevel no longer accepts the --set and --reboot arguments,
	  instead telinit and shutdown write these records into utmp and wtmp.

* runlevel(7) man page added to describe the runlevel event, and
	  the implementation of runlevels and System V compatibility in
	  Upstart.  (Bug: #60429)

* telinit will no longer silently ignore the "a", "b" or "c"
	  runlevels.

* telinit now accepts the previously ignored "-e" argument, passing
	  the environment variables given along with the runlevel event.

* telinit now officially accepts the "q"/"Q" and "u"/"U" arguments,
	  the former will reload the Upstart configuration while the latter
	  will re-execute Upstart.

* telinit q will also attempt to reconnect to the D-Bus system bus
	  if the connection has not been made, or has been lost.
	  (Bug: #323022)

* reboot no longer silently ignores the "-t" option.

* reboot now silently ignores the "-n", "-i" and "-h" options; it
	  will no longer sync your disks, down your network interfaces or
	  spin down your hard drives.  This functionality is all handled
	  by the kernel on a modern system.  (Bug: #92685)

* reboot now writes a "shutdown" record to /var/log/wtmp, this means
	  that the "-w" option is honoured with its original intent.  We
	  still silently ignore the "-d" option.

* shutdown message generation fixed to be more easily translatable.
	  (Bug: #102565)

* The TERM/KILL timeout, and other system timeouts, now use the
	  monotonic clock so are unaffected by system clock changes.
	  (Bug: #389588)

* Respawn detection now uses the monotonic clock so is unaffected
	  by system clock changes.  (Bug: #389586)

* Significant improvement in the amount of manual pages included
	  with Upstart and their content.  (Bug: #60429)

* A manual page refering people from /etc/inittab to /etc/init
	  is also included.  (Bug: #72058)

Changed in upstart:
assignee:	nobody → Scott James Remnant (scott)
status:	Fix Committed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-07-09:

This bug was fixed in the package upstart - 0.6.0-1

---------------
upstart (0.6.0-1) karmic; urgency=low

  * New upstream release ("How appropriate, you fight like a cow")
    - my customary changes list since pointless, it's basically a
      complete rewrite.
    - Handles /bin/sh symlink disappearing. LP: #65024.
    - Boot parameters may be passed to init scripts. LP: #74664.
    - reboot implies --force during shutdown. LP: #388738.
    - reboot no longer iterates /proc/ide. LP: #92685.
    - much improved documentation. LP: #60429, #72058, #388715.