sudo doesn't strip quotes from /etc/environment

As far as I can see, pam_env already strips quotes. Here's the code:

        /* now we try to be smart about quotes around the value,
           but not too smart, we can't get all fancy with escaped
           values like bash */
        if (key[i] == '=' && (key[++i] == '\"' || key[i] == '\'')) {
            for ( t = i+1 ; key[t] != '\0' ; t++)
                if (key[t] != '\"' && key[t] != '\'')
                    key[i++] = key[t];
                else if (key[t+1] != '\0')
                    key[i++] = key[t];
            key[i] = '\0';
        }

Is this not working for you?

Ah it seems it's not systematic; I get it with "sudo -i" or "env -i sudo -i".

I see that pam_env is only enabled for some services, but not for sudo.

Sorry for wrongly assuming this was pam_env; this lead me to think that the fix would be intrusive in pam_env and a change in localechooser had to be considered, but that's not the case, it's just sudo not using the same algorithm:
/*
 * Read in /etc/environment ala AIX and Linux.
 * Lines are in the form of NAME=VALUE
 * Invalid lines, blank lines, or lines consisting solely of a comment
 * character are skipped.
 */
void
read_env_file(path, replace)
    const char *path;
    int replace;
{
    FILE *fp;
    char *cp;

    if ((fp = fopen(path, "r")) == NULL)
        return;

    /* Make sure we are operating on the current environment. */
    if (env.envp != environ)
        sync_env();

    while ((cp = sudo_parseln(fp)) != NULL) {
        /* Skip blank or comment lines */
        if (*cp == '\0')
            continue;

        /* Must be of the form name=value */
        if (strchr(cp, '=') == NULL)
            continue;

        insert_env(estrdup(cp), replace ? TRUE : -1, TRUE);
    }
    fclose(fp);
}

I implemented the pam_env logic in sudo; see attached debdiff which I'd like someone to proofread.

This is the testsuite I've put in /etc/environment along with the outputs of env in sudo -i and in env -i su - -c env:
test sudo pam_env
----------------------------------------------------------
FOO0=foo0 FOO0=foo0 FOO0=foo0
FOO1="foo1 FOO1=foo1 FOO1=foo1
FOO2="foo2" FOO2=foo2 FOO2=foo2
FOO3=foo3" FOO3=foo3" FOO3=foo3"
FOO4='foo4 FOO4=foo4 FOO4=foo4
FOO5='foo5' FOO5=foo5 FOO5=foo5
FOO6=foo6' FOO6=foo6' FOO6=foo6'
FOO7='foo7" FOO7=foo7 FOO7=foo7
FOO8="foo8' FOO8=foo8 FOO8=foo8
FOO9="foo'9" FOO9=foo'9 FOO9=foo'9
FOO10='foo"10" FOO10=foo"10 FOO10=foo"10
FOO11='foo"11 FOO11=foo"11 FOO11=foo"11
FOO12="foo'12 FOO12=foo'12 FOO12=foo'12
FOO13='foo"13 FOO13=foo"13 FOO13=foo"13
FOO14=foo"14' FOO14=foo"14' FOO14=foo"14'
FOO15=foo'15" FOO15=foo'15" FOO15=foo'15"
FOO16=foo'16 FOO16=foo'16 FOO16=foo'16
FOO17=foo"17 FOO17=foo"17 FOO17=foo"17

(so the results match between pam_env/su and sudo)

This is another test run, adding also the results with the current ("old") sudo and some tests for "export".

test new sudo pam_env old sudo
----------------------------------------------------------
FOO0=foo0 FOO0=foo0 FOO0=foo0 FOO0=foo0
FOO1="foo1 FOO1=foo1 FOO1=foo1 FOO1="foo1
FOO2="foo2" FOO2=foo2 FOO2=foo2 FOO2="foo2"
FOO3=foo3" FOO3=foo3" FOO3=foo3" FOO3=foo3"
FOO4='foo4 FOO4=foo4 FOO4=foo4 FOO4='foo4
FOO5='foo5' FOO5=foo5 FOO5=foo5 FOO5='foo5'
FOO6=foo6' FOO6=foo6' FOO6=foo6' FOO6=foo6'
FOO7='foo7" FOO7=foo7 FOO7=foo7 FOO7='foo7"
FOO8="foo8' FOO8=foo8 FOO8=foo8 FOO8="foo8'
FOO9="foo'9" FOO9=foo'9 FOO9=foo'9 FOO9="foo'9"
FOO10='foo"10" FOO10=foo"10 FOO10=foo"10 FOO10='foo"10"
FOO11='foo"11 FOO11=foo"11 FOO11=foo"11 FOO11='foo"11
FOO12="foo'12 FOO12=foo'12 FOO12=foo'12 FOO12="foo'12
FOO13='foo"13 FOO13=foo"13 FOO13=foo"13 FOO13='foo"13
FOO14=foo"14' FOO14=foo"14' FOO14=foo"14' FOO14=foo"14'
FOO15=foo'15" FOO15=foo'15" FOO15=foo'15" FOO15=foo'15"
FOO16=foo'16 FOO16=foo'16 FOO16=foo'16 FOO16=foo'16
FOO17=foo"17 FOO17=foo"17 FOO17=foo"17 FOO17=foo"17
export FOO=foo FOO=foo FOO=foo export FOO=foo
export F="f" F=f F=f export F="f"

This bug was fixed in the package sudo - 1.7.0-1ubuntu2

---------------
sudo (1.7.0-1ubuntu2) karmic; urgency=low

  * env.c: add logic similar to pam_env's stripping of single and double
    quotes around /etc/environment env vars; fixes literal quotes in LANG when
    using sudo -i; LP: #387262.

 -- Loic Minier <email address hidden> Mon, 22 Jun 2009 18:03:45 +0200