move of bzrlib.util.bencode into bzrlib.bencode breaks bzr-gtk
Bug #385212 reported by
GuilhemBichot
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
Unassigned | ||
Bazaar GTK+ Frontends |
Fix Released
|
Undecided
|
Jelmer Vernooij |
Bug Description
In revision
4410 revid:<email address hidden>
of bzr.dev, bencode.py moved from bzrlib.util to bzrlib. Thus, code like:
commit.py:from bzrlib.util import bencode
revisionview.
of bzr-gtk breaks. bzr-gtk needs an update, or bzrlib needs a backward compatibility feature...
Related branches
lp:~jameinel/bzr/1.16-bencode-compat-385212
- Andrew Bennetts: Approve
- Diff: 43 lines
tags: | added: mysql |
Changed in bzr-gtk: | |
assignee: | nobody → Jelmer Vernooij (jelmer) |
status: | New → Fix Released |
To post a comment you must log in.
I had to do such fix in our MySQL-internal plugin:
-from bzrlib.util import bencode
+try:
+ from bzrlib import bencode
+except ImportError: # bencode was in "util" in the past
+ from bzrlib.util import bencode
because it has to work with pre-rename and post-rename bzr (colleagues may upgrade our plugin without upgrading bzr).
Maybe bzr-gtk needs to do the same?