Autouseradd is never silent
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
BeBot |
Fix Released
|
Low
|
Thomas Juberg |
Bug Description
Even if you configure "!set Autouseradd Notify off" users get still notified when they are added to the bot.
The reason might be a wrong parameter count for the user_add function:
/modules/
$this -> bot -> core("user") -> add($this -> bot -> botname, $name, 0, MEMBER, 0, $silent);
/core/User.php, line 69:
function add ($source, $name, $id=0, $user_level, $silent=0)
As you can see, the parameter count differs and so the function is ALWAYS called with 0 for silent parameter, and the last parameter $silent is dropped.
Solution: Remove "0, " in Autouseradd.php
---
As a long-term solution the code should be cleaned up to not intentionally throw php warnings! Then E_WARNING could be turned on without filling the screen with useless information and such errors could be found instantly.
Changed in bebot: | |
status: | Fix Committed → Fix Released |
Fix committed.
A long term solution would be to do a proper cleanup indeed. Hopefully someone will find the time to start working on that eventually.
Patches are most welcome as well.