--bindmounts does not accept space-delimited list

Bug #376612 reported by Timo Reimann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pbuilder (Ubuntu)
Fix Released
Undecided
Loïc Minier

Bug Description

Binary package hint: pbuilder

In pbuilder version 0.183ubuntu1 (which comes with Jaunty), the man-pages states for `--bindmounts':

--bindmounts bind-mount-points
              Bind-mount the specified directories to inside the chroot. bind-mount-points is a space-delimited list of
              directories to bind-mount.

However, when I specify multiple directories in such a space-delimited list, only the very first argument to `--bindmounts' will actually be bind-mounted.

Note that applying the `--bindmounts' option multiple times with a separate directory for each switch actually does what is expected, i.e., bind-mounts multiple directories. Therefore, if this bug can be reproduced successfully, either pbuilder's man-page or implemented should be adjusted (IMHO).

Related branches

Revision history for this message
Loïc Minier (lool) wrote :

You need to quote the list for your shell, e.g.:
  --bindmounts "foo bar"

This wont work:
  --bindmounts foo bar

This is because pbuilder gets two arguments in the first case and three in the second case.

Closing this bug; let me know if you think this is still an issue.

Thanks,

Changed in pbuilder (Ubuntu):
status: New → Invalid
Revision history for this message
Timo Reimann (timo.reimann) wrote :

Loïc, thanks for the explanation regarding quoting.

However, my opinion is that the man-page should mention the necessity of quoting. In fact, it does so for the --removepackages option which accepts a space-delimited list as well, but misses that information for --bindmounts (and --extrapackages as well).

I'm not sure whether this suffices for re-opening this very bug or whether a new, more specific one should be created instead. IMHO, the latter seems like the cleaner approach.

Revision history for this message
Loïc Minier (lool) wrote :

I fixed that in the upstream git repo now for consistency, so --bindmounts now mentions that you need quotes. However I'm not sure this will stay forever, general quoting advice might move to a separate section related to shell usage in the future -- I don't think it's very elegant to remind of the behaviour of the shell for every option.

Thanks,

Changed in pbuilder (Ubuntu):
status: Invalid → Fix Committed
assignee: nobody → Loïc Minier (lool)
Revision history for this message
Timo Reimann (timo.reimann) wrote :

I agree about your idea on putting quoting notes in a central section.

Thanks for the commit.

Revision history for this message
Maarten Bezemer (veger) wrote :

The man page update is available in the packages, so I'll close this issue as fix released.

Changed in pbuilder (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.