from launchpad.codestandards import XXX

Bug #3732 reported by Steve Alexander
16
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned

Bug Description

from launchpad.codestandards import XXX

XXX('SteveA', '2005-10-31', 'Here is an xxx comment about something', bug=1234, spec='FixBadStuff')

Have a report after test runs saying what XXXs were triggered. Have XXX leave stuff on the stack so that it can be noted in tracebacks in production. Have a report to get owners to improve and ultimately remove their XXX stuff.

Steve Alexander (stevea)
Changed in launchpad:
assignee: nobody → stevea
status: New → Accepted
Revision history for this message
Daniel Silverstone (dsilvers) wrote :

It may be useful to have XXX, TODO, and potentially a few other types of what I think we could sanely term 'Active code commentary'

Revision history for this message
Dafydd Harries (daf) wrote :

A suggestion: we provide a function XXX now that does very little -- maybe even nothing. Developers can start using it now, and in the future the test suite and traceback integration can be added.

Revision history for this message
Jonathan Lange (jml) wrote :

Bug 78471 suggests adding something to the 'make check' process that looks for comments themselves, rather than a special XXX function.

This probably should go into 'make lint' or 'make xxx' rather than 'make check'.

Revision history for this message
Joey Stanford (joey) wrote :

For my purposes, I need the following:

A program (could be stand-alone, make check, pydoctor, etc) that can search RF and display XXX comment blocks

   1. Display program name/path
   2. Display entire comment block containing XXX
   3.Tally up total XXX comment blocks in each program/module
   4. Must support multi-line XXX comment blocks

Revision history for this message
Joey Stanford (joey) wrote :

Curtis found a ready-made zope reporter which seems to do exactly what I specified above. He's going to attempt this for FiF.

http://cvs.zope.org/Zope3/utilities/XXXreport

Revision history for this message
Curtis Hovey (sinzui) wrote :

I'll get this started with the XXXreport and XXXreport2html.py from zope. It's easy to modify. We may be able to stretch it to satisfy this bug's requirements.

Changed in launchpad:
assignee: stevea → sinzui-is
status: Confirmed → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Well I did not get to this on Friday day. It was an interesting problem so I worked on it after hours. Now the bash script and python formatter worked after a few minutes of changes, I didn't care for how it operated. So I wrote my own. I don't consider it done, but it did not take long to get something functional I have a sample at
https://devpad.canonical.com/~curtis/xxxreport.html.

I would do a few things differently from the report that I based this on:
1. Link all identified bugs to launchpad.
2. Identify the author and date of the bug and format them for easy reading.
3. Group the comments by file and include a summary of linked bugs.

Revision history for this message
Joey Stanford (joey) wrote :

Steve suggested we add the total count to cricket so we can track the volume of XXXs in the code over time. This would enable us to see if we're getting better or worse.

Revision history for this message
Joey Stanford (joey) wrote :

Cricket appears to be able to easily incorporate the data. Another option is to save the current number on each cron job (append to file) and then, using cron, run plot to produce the graph.

Revision history for this message
Diogo Matsubara (matsubara) wrote :

Re-target to 1.1.8 as Curtis had to work on more urgent things.

Revision history for this message
Curtis Hovey (sinzui) wrote :

While I did not get the time to complete this issue I did add the CSV option. I have it linked from the HTML report I'm generating:
https://devpad.canonical.com/~curtis/xxxreport.html.

I have two steps left to do. Firstly, This must be integrated into cricket, and I'll be getting the assistance of others to do this. I think this implies I'll be writing a log analyser, possibly like the OOPS reports. Secondly, the HTML/CSV report work is poorly tested, and that must be addressed.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Moving this 1.1.10 since I had only half the development time.

Revision history for this message
Curtis Hovey (sinzui) wrote :

Moving this back a release since I've taken on some extra tasks for 1.1.10.

Revision history for this message
Curtis Hovey (sinzui) wrote :

This issue is not important enough to commit to a milestone, but it will be worked on as my schedule permits. There are some opportunities to make use of the forthcoming event logging API.

Changed in launchpad:
milestone: 1.1.11 → none
Revision history for this message
Curtis Hovey (sinzui) wrote :

I'm lowering this because I have not worked on this for 9 months. When this is scheduled, It will have a high priority.

Changed in launchpad:
importance: Medium → Low
Revision history for this message
Curtis Hovey (sinzui) wrote :

Since we decided that reporting the number XXX is more appropriate so that we cover non-python files, I think this bug can be closed as fix released.

However If we still want a cricket report, I'll keep this bug inprogress.

Revision history for this message
Joey Stanford (joey) wrote :

I think we can transfer the cricket portion over to the LOSAs to handle.

Revision history for this message
Curtis Hovey (sinzui) wrote :

I'm marking this fix released. I'll open another bug regarding reporting the count of XXX in the tree in cricket.

Changed in launchpad-foundations:
status: In Progress → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.