Fails to set CPU governor

Bug #37252 reported by Paul Swartz
32
Affects Status Importance Assigned to Milestone
laptop-mode-tools (Ubuntu)
Fix Released
Medium
Daniel Silverstone

Bug Description

Even if l-m-t is set to control the CPU frequency, it does not set the CPU governor due to an error in the script. Line 606 should read $THIS_CPU_GOVERNOR rather than THIS_GOVERNOR.

Revision history for this message
Paul Swartz (paulswartz) wrote : patch to change THIS_GOVERNOR to THIS_CPU_GOVERNOR

A simple fix, a simple patch.

Revision history for this message
Richard Laager (rlaager) wrote :

I can confirm that I had this same problem, and the fix is correct. I filed it in 38133, but then closed that as a duplicate once I found this report.

Revision history for this message
Alexander Oltu (sazs) wrote :

I confirm that bug and solution. But still wonder why not version 1.30 which is aready in debian?

Revision history for this message
Richard Laager (rlaager) wrote :

Justification: CPU scaling is critical to laptop battery life.

Richard Laager (rlaager)
Changed in laptop-mode-tools:
status: Unconfirmed → Confirmed
Revision history for this message
Toby Smithe (tsmithe) wrote :

And this hasn't still been fixed why...

Revision history for this message
Richard Laager (rlaager) wrote :

Matthew Garrett said he would prefer to remove this code rather than make it work. Apparently, powernowd is "the way" to do CPU scaling in Ubuntu. The only problem I see with that is that powernowd doesn't scale second CPUs, so if you have a Core Duo, you're out of luck. That bug will be fixed, though.

Revision history for this message
Toby Smithe (tsmithe) wrote : Re: [Bug 37252] Re: Fails to set CPU governor

Well, that's ok then. I'll just have to find out how to configure powernowd.
I really don't like laptop-mode anyway; it seems a very crude way of getting
the job done - and it doesn't work very well either...

On 03/05/06, Richard Laager <email address hidden> wrote:
>
> Matthew Garrett said he would prefer to remove this code rather than
> make it work. Apparently, powernowd is "the way" to do CPU scaling in
> Ubuntu. The only problem I see with that is that powernowd doesn't scale
> second CPUs, so if you have a Core Duo, you're out of luck. That bug
> will be fixed, though.
>
> --
> Fails to set CPU governor
> https://launchpad.net/bugs/37252
>

Revision history for this message
Matt Zimmerman (mdz) wrote :

(patch available for review)

Changed in laptop-mode-tools:
assignee: nobody → dsilvers
Matthew Garrett (mjg59)
Changed in laptop-mode-tools:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.