Banshee will crash if attempting to remove "New Preset" from equaliser

I think this bug is fixed in Banshee 1.5.0. Could you check? It's in https://launchpad.net/~banshee-unstable-team/+archive/ppa. Thanks.

Seems to be fixed.

On Wed, 2009-06-10 at 13:51 +0000, Mo Abrahams wrote:
> Seems to be fixed.
>
Alrighty then =)
  status fixcommitted
--
Regards,
Chow Loong Jin (GPG: 0x8F02A411)
Ubuntu Contributing Developer

This bug is still present in version 1.5.0-3~hyper1~karmic1 from https://launchpad.net/~banshee-team/+archive/banshee-unstable.

Steps to reproduce:
1. Open banshee
2. Select "View -> Equalizer"
3. Close the dialog ("x")
4. Reopen it ("View -> Equalizer")
5. Click the minus ("-") to remove "New Preset"
6. Banshee crashes

A screencapture is attached. Unfortunately I am not able to get a backtrace with the PPA version (1.5.0-3~hyper1~karmic1), but I was able to get one with version 1.4.3 as in karmic. It's the same way to reproduce so I hope the backtrace from version 1.4.3 is sufficient.

I found the upstream bug and it's indeed fixed...but slightly after version 1.5 (http://git.gnome.org/cgit/banshee/commit/?id=f6b61577f14b4aafb1f9acd7569bcd70033a0d04). The patch has just 8 lines and would qualify for SRU. I will test it and report back tomorrow.

The patch works good. No more chrashes with the ComboBox in the equalizer. Great.

Sorry, this should not have been "fix released".

This bug was fixed in the package banshee - 1.5.1~git2260a87-0ubuntu1

---------------
banshee (1.5.1~git2260a87-0ubuntu1) karmic; urgency=low

  [ Chow Loong Jin ]
  * debian/control, debian/changelog:
    + Use mono-csc instead of csc for MCS.
    + Bump mono-devel version to 2.4.2 for mono-csc

  [ Iain Lane ]
  * Upload upstream snapshot from revision 2260a87. FFe granted on IRC by
    ScottK and sistpoty. Uploading a snapshot as 1.5.1 is almost released,
    which has a lot of improvements over 1.5.0. We have preliminary SRU
    approval to update to 1.5.1 final if it is released after Karmic, subject
    to the usual criteria:

    New Features:

    - Play Queue Auto DJ keeps the tunes coming
    - Shuffle by album and artist
    - Shuffle by weighted rating and score mode
    - Add tooltips for ellipsized ListView text
    - Keep the playing song visible in the track list
    - Add support for WebOS devices
    - Add support for the Samsung Galaxy Android Phone

    Enhancements:

    - When user picks new sort column, default to sort ascending
    - Drop the " Library" suffix on the Music and Video sources
    - Add thin highlight to ListView selection for 3D effect
    - Keyboard shortcut (ESC) to clear the search box
    - Expose LAME's "preset" option
    - Added a --gconf-base-key for running sandboxed
    - Trim URL pasted from clipboard to podcast dialog
    - Allow selection of multiple folders on import
    - Support playlists on Android G1 devices
    - Better support for devices running Rockbox
    - Set video sync folder for Android and WebOS devices
    - Made the error message label selectable
    - Save and load the Gtk.AccelMap
    - Added taglib/oga mimetype to the vorbis audio profile
    - Auto-completion for composer, conductor, grouping and copyright
    - Added the 'comment' search filter
    - Selectable song properties
    - Show a tooltip in track editor when the property is truncated

    Notable bug fixes:

    - Fix blank MimeTypes for tracks ripped before 1.4
    - Fix a Bit Rate column sizing glitch
    - Fix browser positioning when Banshee is maximised
    - Fix compilation metadata reading and writing
    - Work with new notification-daemon
    - Avoid needlessly syncing iPods twice
    - Deterministically sort sources to avoid fluttering
    - Look for Rhythmbox db at both new and old paths
    - Fix bug with scrobbling after skipping a track
    - Fix crash in equalizer
    - Fix an exception on startup when DBus is disabled
    - Fix off-by-one-day date querying bug
    - Fix a UI/spacing glitch in the Smart Playlist Editor
    - Don't hide the track info popup while it has focus
    - Prevent endless "Searching for CD metadata..."
    - Fix Last.fm now-playing for non-decimal track lengths
    - Dispose the SqliteCommand after it's executed
    - Fix notification area popup positioning on multi-monitor systems
    - Fix the playing indicator when song in list more than once
    - Fix crash when opening the profile conf dialog
    - Fix crash stopping jobs on shutdown
    - Fix notification area popup flashing
    - Trim filename dots and spaces to be NTFS compliant
    - Stop playing from audio CD ...