Ubuntu
notify-osd package

icon-only bubbles should fallback to regular bubbles if no icon data exists

Bug #357070 reported by Abhishek Mukherjee
2
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Low
Abhishek Mukherjee

Bug Description

Current design has a notification declared as icon-only that does not have icon-data is not displayed at all. I think such bubbles should instead fallback to a normal notification layout, rather than ignoring the notification in its entirety. This would probably be what would be shown by other galago compliant notification systems which do not listen for x-canonical-private-icon-only.

Steps to reproduce:
1) run `notify-send "Icon" "Only" -i notification-keyboard-brightness -h string:x-canonical-private-icon-only:`
2) run `notify-send "No" "Display" -h string:x-canonical-private-icon-only:`

Revision history for this message
Abhishek Mukherjee (linkinpark342) wrote :

The all of the one line change to do this.

Revision history for this message
Abhishek Mukherjee (linkinpark342) wrote :

Taking this bug since the patch is already below...

Changed in notify-osd:
assignee: nobody → linkinpark342
Revision history for this message
Abhishek Mukherjee (linkinpark342) wrote :

So we can all agree no one codes anything right the first time, realized in the middle of this class that I wasn't actually falling back but actually forcing an improper layout, fixed code to follow:

Revision history for this message
Mirco Müller (macslow) wrote :

I've included your patch in notify-osd trunk. Furthermore we also added this suggested layout-fallback-behaviour to the notify-osd spec. A little correction on your provided test-cases. The first one should read:

notify-send "Icon" "Only" -i notification-keyboard-brightness-high -h string:x-canonical-private-icon-only:
(should result in an icon-only bubble with the full keyboard-brightness icon)

The second one should read:
notify-send "No" "Display" -h string:x-canonical-private-icon-only:
(should result in an summary-body bubble)

Changed in notify-osd:
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mirco Müller (macslow) wrote :

I've applied and tested you latest patch to trunk. Fall back works ok from what I can tell.

Changed in notify-osd:
status: In Progress → Fix Committed
Neil J. Patel (njpatel)
Changed in notify-osd:
status: Fix Committed → Fix Released
Matthew Paul Thomas (mpt)
affects: notify-osd → notify-osd (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.