it does not follow the notify-osd icon spec

Hello,

I would like to get a fix for this as a Jaunty SRU when the Jaunty updates archive opens after the release. I have built a package of a fix, could the reporters on this bug please confirm whether or not this updated package fixes the issue?

  https://launchpad.net/~ted-gould/+archive/bugfix

Thank you.
Ted

I installed your version 0.14-1ubuntu9
It's not fixed. the msn butterfly icon is still chosen instead of the new one.

On Tue, 2009-04-21 at 16:40 +0000, Nicolò Chieffo wrote:
> I installed your version 0.14-1ubuntu9
> It's not fixed. the msn butterfly icon is still chosen instead of the new one.

This is the intended behavior. If there is a better icon, a user icon
or a protocol icon, that is used. If there is not, it will use the
generic instant message icon. The fix is that previously no icon was
used in those cases.

Ok if so, I can't find a case in which the new icon is used. a
protocol icon is always available

On Tue, 2009-04-21 at 18:58 +0000, Nicolò Chieffo wrote:
> Ok if so, I can't find a case in which the new icon is used. a
> protocol icon is always available

The biggest one for me was IRC when people do private messages. I get
the icon in that case now.

That's strange... why isn't the irc icon used?
if in msn the butterfly icon is used, in irc this should be used
/usr/share/pixmaps/pidgin/protocols/48/irc.png

The pidgin-libnotify package in the jaunty-proposed queue changes this. However, this violates UI freeze, and does not really fit the SRU criteria either. Can you please update this bug to explain SRU rationale, etc., and a clearer description what this changes? (screenshots, etc.)

On Thu, 2009-04-23 at 09:45 +0000, Martin Pitt wrote:
> The pidgin-libnotify package in the jaunty-proposed queue changes this.
> However, this violates UI freeze, and does not really fit the SRU
> criteria either. Can you please update this bug to explain SRU
> rationale, etc., and a clearer description what this changes?
> (screenshots, etc.)

I have a hard time saying this violates the UI freeze as it's a fallback
icon being used when there isn't any more valuable data to put there.
The spirit of the UI freeze is to help documentation and screenshot
based features, I'd be surprised if any of those used a fallback anyway.
I don't think that's an issue.

In the attached screenshot you can see the icon if one is using the
Human theme. Previously the bug was that there wasn't an icon in cases
where Pidgin doesn't provide one. In almost all messages there is an
icon, the bug was that some didn't have an icon.

Ah, I misunderstood the description then, thanks.

Accepted pidgin-libnotify into jaunty-proposed; please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Mmmm... why don't you use the IRC icon instead? Or instead change the IRC icon to the one proposed in notify-osd?
I don't see the point of this patch: if IRC is the only protocol affected we should fix the code upstream.

On Fri, 2009-04-24 at 12:18 +0000, Nicolò Chieffo wrote:
> Mmmm... why don't you use the IRC icon instead? Or instead change the
> IRC icon to the one proposed in notify-osd?
> I don't see the point of this patch: if IRC is the only protocol
> affected we should fix the code upstream.

There are also other protocols that don't have icons. The patch is
saying that the default should be this icon. I just have an example
that involves IRC. Yes, I think that it's odd that Pidgin reports it
doesn't have an icon for private messages on IRC, and that should be
fixed in the IRC protocol handler. But, that doesn't invalidate the
need for this patch as the spec states that this icon should be used as
the fallback, which the plugin is currently not doing.

I removed this from jaunty-proposed. It didn't get any feedback, it is still not fixed in karmic, and bug 351545 is verification-failed.

2009-09-09 09:58:33 INFO Removing candidates:
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty amd64
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty armel
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty hppa
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty i386
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty ia64
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty lpia
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty powerpc
2009-09-09 09:58:33 INFO pidgin-libnotify 0.14-1ubuntu9 in jaunty sparc
2009-09-09 09:58:33 INFO Removed-by: Martin Pitt
2009-09-09 09:58:33 INFO Comment: unverified/failed SRU
2009-09-09 09:58:33 INFO 9 packages successfully removed.
2009-09-09 09:58:33 INFO Transaction committed.

This bug was fixed in the package pidgin-libnotify - 0.14-1ubuntu10

---------------
pidgin-libnotify (0.14-1ubuntu10) karmic; urgency=low

  * Adding in blacklist support
  * Trying to fix IRC first messages by using an idle function
    to wait for the conversation to get built.
  * Changing black list to be a plugin preference.
  * Adding checking for the server
  * /debian/patches/indicate.patch:
    * Updating to use the libindicate v2 interface (LP: #424487 and
      LP: #424491)
    * Merging in Ken Vandine's patch to make the Pidgin window always
      rise on click from the indicator applet. (LP: #354026)
    * Starting a blacklist for common IRC server nicks. (LP: #362660)
    * Making it so that no append hint is sent on connection status
      messages. (LP: #361800)
    * Setting the default icon to match the notify-osd specification
      if there is no better icon available. (LP: #356979)
    * Making the login timeout 60 seconds instead of 15 so that the
      indicator applet doesn't flicker.
    * Changing the logic slightly so that if we don't have a GUI window
      then we don't check for focus. We only block notifications/indicators
      we we both have a GUI and have focus. (LP: #351545)
  * Adding debian/patches/indicate-autotools.patch changes to built
    files from above patch.
  * debian/control:
    * Increasing libindicate dependency to 0.2.0
    * Adding a build dependency on libindicate-gtk-dev

 -- Ted Gould <email address hidden> Wed, 16 Sep 2009 14:10:37 -0500