Ubuntu
notify-osd package

unref original pixbuf in bubble_set_icon_from_pixbuf when scaling

Bug #356913 reported by Eitan Isaacson
2
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Medium
Mirco Müller

Bug Description

The pointer is overwritten before the pixbuf's ref count is decreased.

Tags: memleak
Revision history for this message
Eitan Isaacson (eeejay) wrote :
Eitan Isaacson (eeejay)
tags: added: memleak
Revision history for this message
Cody Russell (bratsche) wrote :

I think I fixed this in https://bugs.edge.launchpad.net/notify-osd/+bug/338483 but it hasn't been merged in yet.

Revision history for this message
Mirco Müller (macslow) wrote :

Cody, I didn't merge that yet, because when I tried and reviewed it, it showed that it was incomplete. scale_pixbuf () isn't called at the right time (or at all). Before I can merge that I've to fix it. Some rework of stack might be needed as well. At the moment the amount of things I've to try to finish before freeze is huge. I don't want to commit to things I'm uncertain to be able to fulfill.

Revision history for this message
Cody Russell (bratsche) wrote :

That's fine, we should get this patch from Eitan in at least though.

Mirco Müller (macslow)
Changed in notify-osd:
assignee: nobody → Mirco Müller (macslow)
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Alexander Sack (asac) wrote :

seems to be fixed in latest release. please verify and reopen if thats not the case. Thanks!

Changed in notify-osd:
status: Fix Committed → Fix Released
Matthew Paul Thomas (mpt)
affects: notify-osd → notify-osd (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.