pybootchartgui crashed with ValueError in _parse_proc_ps_log()

Hi,

Can you upload your /var/log/bootchart.tgz file? Then I will try to reproduce the bug.

Thanks
Anders

This is a .tgz file from today. I looked at the /var/log/bootchart directory now and saw that once on 13 times pybootchartgui produce a .png out from .tgz yesterday.

And this is a .tgz which a successful produced .png was from

Thanks.

It seems that process commands can have a space in them and that you have such processes sometimes. See (cx88 tvaudio) in

1573 (cx88 tvaudio) S 2 0 0 0 -1 2149589056 0 0 0 0 0 0 0 0 15 -5 1 0 1738 0 0 4294967295 0 0 0 0 0 0 0 2147483647 0 3222553813 0 0 17 0 0 0 0 0 0

This confuses the parser. I'll try to fix it.

Best,
Anders

If you always expect tokens to be of length 44, the attached patch should fix it.

Yes.

In all recent bootchart dumps I have there 44 tokens (or 45 like above). In the example files from 2005 in the original java bootchart project the lines have 41 tokens.

Hmm, I should probably just count on the 44 token format and do something like your patch.

Thanks,
Anders

Confirming the issue for revision 113

By the way: The patch seems to work fine.

Fix committed as r116

http://code.google.com/p/pybootchartgui/source/detail?r=116

Woops, r116 is broken, r117 fixes this

http://code.google.com/p/pybootchartgui/source/detail?r=117

"Woops, r116 is broken, r117 fixes this

http://code.google.com/p/pybootchartgui/source/detail?r=117"

So, how can a end-user apply this patch in order to fix this bug? Is there any updated deb?

wingnux, I am working on getting a new revision of pybootchaartgui into Jaunty before release, so you should be able to get a new deb in two weeks when Jaunty will be released.

wingnux, I have uploaded revision 120 to my PPA: https://launchpad.net/~mrkanister/+archive/ppa

You can download it from there if you like to test it.

Thank you VERY MUCH! I've installed the updated deb and now I get a valid png file on /var/log/bootchart! =)

Yes, I can confirm. Revision r124 from your Launchpad repo works just fine. Good job! Keep that way :-)

This bug was fixed in the package pybootchartgui - 0+r124

---------------
pybootchartgui (0+r124) jaunty; urgency=low

  * New upstream revision:
    - Fix some drawing issues (lp: #342593)
    - Fix drawing bug (lp: #343215)
    - Empty bootcharts are now discovered (lp: #355952)
    - Fix incorrect seconds value for 60+ second boots (lp: #355954)
    - Fix parsing issue for process lines with spaces (lp: #356537)
    - Update slider position when zooming (lp: #358364)
    - Fix some drawing issue (lp: #360943, thanks to Hernando Torque)
  (thanks to biehl and Henning Niss for their active development)
  * debian/control:
    - Add depencies to 'python-gtk2' and 'python-cairo' (lp: #353699)

 -- Martin Mai <email address hidden> Sat, 18 Apr 2009 22:48:24 +0200