alltray trayicons use their own tooltip theme

Bug #355077 reported by Martin Mai
4
Affects Status Importance Assigned to Milestone
AllTray
Fix Released
Low
Unassigned
alltray (Debian)
Fix Released
Unknown
alltray (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: alltray

Alltray should not use its own tooltip theme for the trayicon it adds. It should use the system theme.

I have attached some screenshots showing the issue (The evolution trayicon was added with alltray).

Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :
Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your bug report, evolution has no notification area icon by default how did you enable this one?

Changed in evolution (Ubuntu):
assignee: nobody → desktop-bugs
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Doh...I am using alltray do do this...sorry

affects: evolution (Ubuntu) → alltray (Ubuntu)
Changed in evolution (Ubuntu):
assignee: desktop-bugs → nobody
summary: - evolution trayicon uses its own tooltip theme
+ alltray trayicons use their own tooltip theme
Changed in alltray (Ubuntu):
status: Incomplete → New
description: updated
Revision history for this message
Michael B. Trausch (mtrausch) wrote :

AllTray has been modified to not use the pop-up bubble; see the referenced bzr branch.

To Ubuntu: You can update your copy of AllTray in the distribution from this branch if you desire, to fix this bug in Ubuntu itself. See the referenced bzr branch for the source diff.

Changed in alltray:
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Kyran Lange (kyranl) wrote :

debdiff to fix this bug is attached.

First debdiff I have done on my own so feedback is welcome :)

Kyran Lange (kyranl)
Changed in alltray (Ubuntu):
status: New → Confirmed
Revision history for this message
Michael B. Trausch (mtrausch) wrote :

Tested building the package with this debdiff applied; looks good to me. Builds just fine and binary package installs and works.

Thanks, Kyran! If you're interested, you may want to prep old-maintenance r26 for upload into Debian so that Jaunty+1 will get it, too.

In fact, you may want to include r26 in your debdiff, which fixes Ubuntu bug 118484 as well.

Revision history for this message
Kyran Lange (kyranl) wrote :

No problem Michael.

I'm only a packaging n00b and don't think I'm ready to prepare packages for Debian yet, but I will research a bit and see whats involved.

Per suggestion have included a patch from r26 to fix #118484 aswell. Updated debdiff is attached.

Revision history for this message
Scott Kitterman (kitterman) wrote :

[21:37:18] <ScottK> Laney: You tested this works?
[21:37:23] <Laney> sure did
[21:37:28] <ScottK> Ack for upload.

Revision history for this message
Iain Lane (laney) wrote :

Uploaded. Thanks for your work here, the patch was just fine. Note that I uploaded the *first* patch; the second patch didn't seem to work properly (windows were still not showing).

Please could you forward this change to Debian? See https://wiki.ubuntu.com/Debian/Bugs for more information.

Changed in alltray (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package alltray - 0.69-1ubuntu3

---------------
alltray (0.69-1ubuntu3) jaunty; urgency=low

  * Fix "alltray trayicons use their own tooltip theme" (LP: #355077) by
    adding 10-dont-use-pop-up-bubble.dpatch.

 -- Kyran Lange <email address hidden> Thu, 16 Apr 2009 12:40:32 +0930

Changed in alltray (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Michael B. Trausch (mtrausch) wrote : Re: [Bug 355077] Re: alltray trayicons use their own tooltip theme

On Sun, 19 Apr 2009 01:44:18 -0000
Iain Lane <email address hidden> wrote:

> Uploaded. Thanks for your work here, the patch was just fine. Note
> that I uploaded the *first* patch; the second patch didn't seem to
> work properly (windows were still not showing).

Hrm... the second patch worked for me... what environment are you using?

 --- Mike

--
And what's the internet without the rick-roll?
                            --- Linus Torvalds, on RH bug 439858

Revision history for this message
Kyran Lange (kyranl) wrote :

Yes, worked for me aswell.

Will attach a separate debdiff to bug 118484 now to fix that bug as i guess the debdiff has to be against 0.69-1ubuntu3 now.

Revision history for this message
Kyran Lange (kyranl) wrote :

I have forwarded this change to debian.

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524683

Changed in alltray (Debian):
status: Unknown → New
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Wow, thanks a lot for updating that for jaunty. I have not expected to see this fixed before new (rewritten) version of alltray will be released.

Revision history for this message
Michael B. Trausch (mtrausch) wrote :

On Sun, 19 Apr 2009, Martin Mai wrote:

> Wow, thanks a lot for updating that for jaunty. I have not expected to
> see this fixed before new (rewritten) version of alltray will be
> released.

It was trivial enough that I went ahead and fixed it in the maint. tree, but
wasn't sure if anyone was going to be able to get it in for jaunty. I am glad
they did. :)

Changed in alltray:
status: Fix Committed → Fix Released
Changed in alltray (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.