Ubuntu
notify-osd package

rhythmbox notifications with "&" in song title seem to be missing

Bug #353398 reported by dobey
8
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Medium
Mirco Müller

Bug Description

When switching through the songs in my library when I hit a song that has an ampersand (&) character in the song title, there is no notification which pops up.

dobey (dobey)
Changed in notify-osd:
assignee: nobody → bratsche
Revision history for this message
Cody Russell (bratsche) wrote :

I think since we switched around some of the markup escaping, this regressed. This patch should fix it.

Revision history for this message
Cody Russell (bratsche) wrote :

The last patch breaks things like < and such. This new patch is correct, and is what I now have pushed into the branch linked here.

This will check for & so long as it is not part of:
  &
  <
  >
  "
  '

Revision history for this message
Mark Shuttleworth (sabdfl) wrote : Re: [Dx-team] [Bug 353398] Re: rhythmbox notifications with "&" in song title seem to be missing

Cody Russell wrote:
> The last patch breaks things like < and such. This new patch is
> correct, and is what I now have pushed into the branch linked here.
>
> This will check for & so long as it is not part of:
> &
> <
> >
> "
> '
>

Are there tests for each of the fixes that have been made to our HTML
quoting handling code?

Mark

Revision history for this message
Cody Russell (bratsche) wrote :

Here's a basic unit test for the HTML filtering.

Mirco Müller (macslow)
Changed in notify-osd:
assignee: bratsche → macslow
importance: Undecided → Medium
status: New → Fix Committed
dobey (dobey)
Changed in notify-osd:
status: Fix Committed → Fix Released
Matthew Paul Thomas (mpt)
affects: notify-osd → notify-osd (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.