landscape.lib.fetch doesn't define timeout

One thing for us to keep in mind when introducing the timeout is that we have to put a timeout high-enough to allow for long payloads to be sent to the server. We should probably base the timeout on the server-side timeout, so maybe 5 minutes or more.

This is ready to review in the attached branch. I just defined the 2 timeouts and check the options in the tests.

I've missed that there was a branch up for review, and that you're already using 5 minutes. +1!

Nice, +1.

Thanks, merged in r93.

This bug was fixed in the package landscape-client - 1.0.29-0ubuntu0.9.04.0

---------------
landscape-client (1.0.29-0ubuntu0.9.04.0) jaunty; urgency=low

  * New upstream bugfix release (LP: #358744)
    - Add a timeout to HTTP operations to avoid hanging (LP: #349737)
    - Clean up environment variables on startup to avoid propagating
      variables that will corrupt package installation (LP: #348681)
    - Clean up FDs on startup for the same reason (LP: #352458)
    - Catch and handle certain errors from smart (such as invalid package
      data) to avoid "stuck" Landscape activities (LP: #268745)
    - Don't print warnings meant for developers to the console (LP: #336669)

 -- Christopher Armstrong <email address hidden> Thu, 09 Apr 2009 17:09:50 -0400