REGRESSION: volume labels have underscores instead of spaces

Confirmed this is a behavior change between intrepid and jaunty:

ubuntu@jaunty-i386:~$ sudo tune2fs -l /dev/sda1 | grep -i "uuid\|name"
Filesystem volume name: My Boot
Filesystem UUID: 11bcff22-6f53-41c7-9ea9-6b71dcb195a8
ubuntu@jaunty-i386:~$ lshal -u volume_uuid_11bcff22_6f53_41c7_9ea9_6b71dcb195a8 | grep -i label
  volume.label = 'My_Boot' (string)

However, it's unclear to me whether this is an intended change or if it breaks anything (mounting by label works correctly)

Is this actually breaking anything?

No change to libvolume-id (and using jaunty libvolume-id with intrepid HAL produces same non-escaped result). Escaping must be happening inside HAL.

Note to self: the only relevant change in jaunty was

  http://cgit.freedesktop.org/hal/commit/?id=79b92dbdf65b8c978d5a8f6fb2b421aac83c3de3

I'll reproduce this here and track it down; I agree that it looks like hal, and it does not look like an intended change.

The udev event looks like this:

UDEV [1238756110.231878] add /devices/pci0000:00/0000:00:1d.7/usb1/1-8/1-8.2/1-8.2:1.0/host9/target9:0:0/9:0:0:0/block/sdf/sdf1 (block)
UDEV_LOG=3
ACTION=add
DEVPATH=/devices/pci0000:00/0000:00:1d.7/usb1/1-8/1-8.2/1-8.2:1.0/host9/target9:0:0/9:0:0:0/block/sdf/sdf1
SUBSYSTEM=block
DEVTYPE=partition
SEQNUM=1909
ID_VENDOR=OTi
ID_VENDOR_ENC=OTi\x20\x20\x20\x20\x20
ID_MODEL=Flash_Disk
ID_MODEL_ENC=Flash\x20Disk\x20\x20\x20\x20\x20\x20
ID_REVISION=1.11
ID_SERIAL=OTi_Flash_Disk_F3018E93E8BADA0-0:0
ID_SERIAL_SHORT=F3018E93E8BADA0
ID_TYPE=disk
ID_INSTANCE=0:0
ID_BUS=usb
ID_USB_INTERFACES=:080650:
ID_PATH=pci-0000:00:1d.7-usb-0:8.2:1.0-scsi-0:0:0:0
ID_FS_USAGE=filesystem
ID_FS_TYPE=vfat
ID_FS_VERSION=FAT32
ID_FS_UUID=6E13-F868
ID_FS_UUID_ENC=6E13-F868
ID_FS_LABEL=Pitti_USB
ID_FS_LABEL_ENC=Pitti\x20USB
DEVNAME=/dev/sdf1
MAJOR=8
MINOR=81
DEVLINKS=/dev/block/8:81 /dev/disk/by-id/usb-OTi_Flash_Disk_F3018E93E8BADA0-0:0-part1 /dev/disk/by-path/pci-0000:00:1d.7-usb-0:8.2:1.0-scsi-0:0:0:0-part1 /dev/disk/by-uuid/6E13-F868 /dev/disk/by-label/Pitti\x20USB

Currently, hal uses ID_FS_LABEL, which gets the '_' smuggled in. Should hal use ID_FS_LABEL_ENC instead and decode it somehow, or should udev not mangle ID_FS_LABEL?

For the record, this happens in ./hald/linux/coldplug.c:

   udevdb to UdevInfo struct:

   hal_util_init_sysfs_to_udev_map():

       char *udevdb_export_argv[] = { "/sbin/udevadm", "info", "-e", NULL };
       [...]
         else if (strncmp(line, "E: ID_FS_LABEL=", 15) == 0) {
                info->fslabel = &line[15];

   and further on, conversion to HotplugEvent*:

   static HotplugEvent* udev_info_to_hotplug_event(const UdevInfo *info):

        if ((str = hal_util_strdup_valid_utf8(info->fslabel)) != NULL) {
                g_strlcpy (hotplug_event->sysfs.fslabel, str, sizeof(hotplug_event->sysfs.fslabel));
                g_free (str);
        }

I could probably work around this in hal, but since DeviceKit-disks and probably other parts of the system use the udev database as well, this is IMHO better fixed in udev itself.

The udev information deliberately has character codes stripped, you can use the _ENC to get an encoded version of the unstripped, or if using libudev just request the attribute (which is completely unencoded and unescaped)

Note also that udev has *ALWAYS* behaved this way - HAL simply changed the source of information, it previously got the unescaped/encoded labels

Implemented: http://cgit.freedesktop.org/hal/commit/?id=97b023f94f1d79a19bc0489c0d167bdaebb765fd

This bug was fixed in the package hal - 0.5.12~rc1+git20090403-0ubuntu1

---------------
hal (0.5.12~rc1+git20090403-0ubuntu1) jaunty; urgency=low

  * Update to current git HEAD to collect some more bug fixes:
    - Fix volume label parsing (directly committed upstream) (LP: #347370)
    - Regenerate FDI cache if it's zero sized
    - Fix handling of floppy and MO discs.
    - Fix various memory leaks and unused pointers.
    - Fix linking against libsmbios.
    - Allow specifying a udev dir in etc (Fedora still has udev rules dir in
      /etc)
  * debian/rules: Update --with-udev-prefix according to above upstream
    change.
  * Drop 86_smbios_configure_error.patch, applied upstream.

 -- Martin Pitt <email address hidden> Fri, 03 Apr 2009 17:10:56 +0200