Ubuntu
gedit-plugins package

debian/control: Description shows duplicate lines

Bug #339554 reported by Savvas Radevic
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gedit-plugins (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: gedit-plugins

$ apt-cache policy gedit-plugins
gedit-plugins:
  Installed: 2.25.3-0ubuntu1
  Candidate: 2.25.3-0ubuntu1
  Version table:
 *** 2.25.3-0ubuntu1 0
        500 http://archive.ubuntu.com jaunty/universe Packages
        100 /var/lib/dpkg/status

gedit-plugins shows duplicate lines:
$ apt-cache show gedit-plugins
Package: gedit-plugins
Priority: optional
Section: universe/gnome
Installed-Size: 1768
Maintainer: Ubuntu MOTU Developers <email address hidden>
Original-Maintainer: Loic Minier <email address hidden>
Architecture: amd64
Version: 2.25.3-0ubuntu1
Depends: libatk1.0-0 (>= 1.20.0), libc6 (>= 2.2.5), libcairo2 (>= 1.2.4), libfontconfig1 (>= 2.4.0), libfreetype6 (>= 2.3.5), libgconf2-4 (>= 2.13.5), libglib2.0-0 (>= 2.18.0), libgtk2.0-0 (>= 2.15.0), libgtksourceview2.0-0 (>= 2.3), libgucharmap7 (>= 1:2.23.4), libpango1.0-0 (>= 1.22.0), zlib1g (>= 1:1.1.4), gconf2 (>= 2.10.1-2), python-central (>= 0.6.11), gedit (>= 2.25.3), python-gnome2-desktop (>= 2.15.90), python-gtk2 (>= 2.12.0), python-gobject (>= 2.15.4), python-gnome2, python-glade2, python-vte, python-gtksourceview2 (>= 2.2.0)
Filename: pool/universe/g/gedit-plugins/gedit-plugins_2.25.3-0ubuntu1_amd64.deb
Size: 299902
MD5sum: 5f26cf2edb3a6de60179ff7621acbf36
SHA1: 72d086b8b1ecfaedcef734a1d83369e179bebfd0
SHA256: 25e15d3ce76859c8d7017643664625bdfdca7a67c8bb5e414c35816b348a692c
Description: set of plugins for gedit
 gedit-plugins contain a set of plugins for gedit, GNOME's text editor.
 .
 The following plugins are included:
  * Code comment: Comment out or uncomment a selected block of code.
  * Code comment: Comment out or uncomment a selected block of code.
  * Color Picker: Pick a color from a dialog and insert its hexadecimal representation.
  * Color Picker: Pick a color from a dialog and insert its hexadecimal representation.
  * Draw Spaces: Draw Spaces and Tabs
  * Draw Spaces: Draw Spaces and Tabs
  * Session Saver: Save and restore your working sessions
  * Session Saver: Save and restore your working sessions
  * Bookmarks: Easy document navigation with bookmarks
  * Bookmarks: Easy document navigation with bookmarks
  * Show/Hide Tabbar: Add a menu entry to show/hide the tabbar.
  * Show/Hide Tabbar: Add a menu entry to show/hide the tabbar.
  * Smart Spaces: Forget you're not using tabulations.
  * Smart Spaces: Forget you're not using tabulations.
  * Embedded Terminal: Embed a terminal in the bottom pane.
  * Embedded Terminal: Embed a terminal in the bottom pane.
  * Bracket Completion: Automatically adds closing brackets.
  * Bracket Completion: Automatically adds closing brackets.
  * Join/Split Lines: Join several lines or split long ones
  * Join/Split Lines: Join several lines or split long ones
  * Character Map: Insert special characters just by clicking on them.
  * Character Map: Insert special characters just by clicking on them.
Python-Version: 2.5
Bugs: mailto:<email address hidden>
Origin: Ubuntu

Reason: There are *.desktop.in files and *.desktop.in.in files in the source package. debian/rules scans for *.desktop* files to update the debian/control:

$ find . -iname \*.desktop\*
./plugins/codecomment/codecomment.gedit-plugin.desktop.in.in
./plugins/codecomment/codecomment.gedit-plugin.desktop.in
./plugins/colorpicker/colorpicker.gedit-plugin.desktop.in
./plugins/colorpicker/colorpicker.gedit-plugin.desktop.in.in
./plugins/drawspaces/drawspaces.gedit-plugin.desktop.in.in
./plugins/drawspaces/drawspaces.gedit-plugin.desktop.in
./plugins/sessionsaver/sessionsaver.gedit-plugin.desktop.in
./plugins/sessionsaver/sessionsaver.gedit-plugin.desktop.in.in
./plugins/bookmarks/bookmarks.gedit-plugin.desktop.in.in
./plugins/bookmarks/bookmarks.gedit-plugin.desktop.in
./plugins/showtabbar/showtabbar.gedit-plugin.desktop.in
./plugins/showtabbar/showtabbar.gedit-plugin.desktop.in.in
./plugins/smartspaces/smartspaces.gedit-plugin.desktop.in
./plugins/smartspaces/smartspaces.gedit-plugin.desktop.in.in
./plugins/terminal/terminal.gedit-plugin.desktop.in.in
./plugins/terminal/terminal.gedit-plugin.desktop.in
./plugins/bracketcompletion/bracketcompletion.gedit-plugin.desktop.in
./plugins/bracketcompletion/bracketcompletion.gedit-plugin.desktop.in.in
./plugins/joinlines/joinlines.gedit-plugin.desktop.in
./plugins/joinlines/joinlines.gedit-plugin.desktop.in.in
./plugins/charmap/charmap.gedit-plugin.desktop.in
./plugins/charmap/charmap.gedit-plugin.desktop.in.in

Suggestions:
- Cleanup *.in.in files?
- Also cleanup the already created debian/control?
- Use something like this in debian/rules: find . -not \( -name '*.in.in' \) -a -iname '*desktop*'

See original description
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thank you for your bug report.

Changed in gedit-plugins:
importance: Undecided → Low
status: New → Triaged
Savvas Radevic (medigeek)
description: updated
Revision history for this message
Savvas Radevic (medigeek) wrote :

I'll give it a shot, and also clear up the debian/rules mess (no offense!) :)

Changed in gedit-plugins:
assignee: nobody → medigeek
status: Triaged → In Progress
Revision history for this message
Savvas Radevic (medigeek) wrote :

I was thinking of making a python script, but I managed to "clear up" the script that gets the plugin description. I parsed it in several lines and added proper comments on how it works:

  * Fixed duplicate lines in Description: (LP: #339554)
    + debian/rules: Using *.desktop.in find filename filter
  * debian/rules:
    + Using grep/find/sed only now
    + Added comments about how the plugin description update works
  * Removed debian/desktop2description.awk
  * debian/control.in: Standards-Version to 3.8.0

Revision history for this message
Savvas Radevic (medigeek) wrote :

Here's the patch (debdiff). :)

Revision history for this message
Daniel Holbach (dholbach) wrote :

 - Bumping the Standards-Version for packages that we get from Debian is not really necessary.
 - Why is the GNOME_TEAM replacement necessary? I would've thought that gnome-pkg-tools would take care of that?

Revision history for this message
Savvas Radevic (medigeek) wrote : Re: [Bug 339554] Re: debian/control: Description shows duplicate lines

> - Bumping the Standards-Version for packages that we get from Debian is not really necessary.

I just thought that being a new upstream release and not included in
Debian that we should take care of the policy.
Anyway, it's not important, removed. :)
I've attached the new debdiff!

> - Why is the GNOME_TEAM replacement necessary? I would've thought that gnome-pkg-tools would take care of that?

Daniel, I have tried removing those lines, but it looks like
@GNOME_TEAM@ isn't replaced because there already exists a sed -e
substitution.

Found something in the changelog:
"* Drop superfluous uploaders include.
[...]
* Set DISABLE_UPDATE_UPLOADERS; build-dep on gnome-pkg-tools >= 0.11."

Revision history for this message
Savvas Radevic (medigeek) wrote :

OK, after talking with hyperair on #ubuntu-motu about this:
- uploaders.mk does actually change the debian/control.in to debian/control

- Commenting out (in debian/rules) DISABLE_UPDATE_UPLOADERS and removing the '-e "s#@GNOME_TEAM@#$(UPLOADERS)#g" \' part, then debian/rules attempts to change debian/control.in again, but doesn't change the @GNOME_TEAM@ (it basically overwrites the already changed debian/control).
(This could be easily fixed using sed -i -e 's/.../.../' debian/control)

- By using DISABLE_UPDATE_UPLOADERS we disable this, and give more power to the maintainer to handle changes and @tags@ in debian/control.in

Savvas Radevic (medigeek)
Changed in gedit-plugins:
assignee: medigeek → nobody
status: In Progress → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gedit-plugins - 2.26.0-0ubuntu2

---------------
gedit-plugins (2.26.0-0ubuntu2) jaunty; urgency=low

  * No-change rebuild (LP: #346329)
  * debian/control.in:
    - Remove duplicated plugins in long description: Search for *.desktop.in.in
      instead of *.desktop* (which fits for *.desktop.in and *.desktop.in.in).
      (LP: #339554)
    - Sort plugins in long description.

 -- Benjamin Drung <email address hidden> Sat, 21 Mar 2009 14:03:14 +0100

Changed in gedit-plugins:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.