images are displayed with an incorrect ratio

Bug #338483 reported by Sebastien Bacher
18
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Fix Released
Medium
Cody Russell
pidgin-libnotify (Ubuntu)
Fix Released
High
Cody Russell

Bug Description

* start pidgin
* add vuntz to your jabber contacts (or somebody else who has a photo configured, but vuntz he somebody nice to have in his buddylist ;-)
* wait for him to get online
* notice the nice bubble displayed to say that vuntz is online
* notice the not-so-nice photo in the bubble, the ratio is clearly wrong, that's a shame to have vuntz displayed wrongly!

<https://wiki.ubuntu.com/NotifyOSD#Icon>: "Any icon should be scaled so that its largest dimension is 3 ems."

Revision history for this message
Ted Gould (ted) wrote :

This is especially noticible on accounts from Facebook where many of the images are 1:2 or 2:3 rather than 1:1.

description: updated
David Barth (dbarth)
Changed in notify-osd:
assignee: nobody → macslow
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Rick Spencer (rick-rickspencer3) wrote :

Cody - perhaps you should be tracking this for Jaunty as well?

Changed in notify-osd (Ubuntu):
assignee: nobody → bratsche
importance: Undecided → High
Changed in notify-osd (Ubuntu):
milestone: none → ubuntu-9.04
Revision history for this message
Cody Russell (bratsche) wrote :

Not ready to merge yet, just wanting to get review.

Revision history for this message
Cody Russell (bratsche) wrote :
Revision history for this message
Cody Russell (bratsche) wrote :

Tested, this one works.

Revision history for this message
Cody Russell (bratsche) wrote :

Ted, I've committed the latest changes to my branch (which is attached to this bug report). Can you merge from me?

Changed in notify-osd:
assignee: macslow → bratsche
status: Confirmed → Invalid
Revision history for this message
Ted Gould (ted) wrote :

Here is a debdiff with this patch and a couple others. Could someone please sponsor it? Here is the changelog:

pidgin-libnotify (0.14-1ubuntu7) jaunty; urgency=low

  * /debian/patches/indicate.patch:
    * Making it so that there is also a function watching for
      destroyed conversations and destroying the indicators if
      they're left on the conversations. This fixes LP: #340717
    * Adjusting the timeout to block new logins when an account
      connects to be 15 seconds. This helps the flood on slow
      connections. Also, made it so that logins raise indicators
      that show up in the indicator applet. Both of these are
      trying to resolve many of the issues in LP: #345494
    * Make it so that icons are scaled to 48x48 at aspect ratio
      so that they don't get squashed. Patch from Cody Russell
      on LP: #338483

 -- Ted Gould <email address hidden> Thu, 19 Mar 2009 22:39:59 -0500

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you ted

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pidgin-libnotify - 0.14-1ubuntu7

---------------
pidgin-libnotify (0.14-1ubuntu7) jaunty; urgency=low

  * /debian/patches/indicate.patch:
    * Making it so that there is also a function watching for
      destroyed conversations and destroying the indicators if
      they're left on the conversations. This fixes LP: #340717
    * Adjusting the timeout to block new logins when an account
      connects to be 15 seconds. This helps the flood on slow
      connections. Also, made it so that logins raise indicators
      that show up in the indicator applet. Both of these are
      trying to resolve many of the issues in LP: #345494
    * Make it so that icons are scaled to 48x48 at aspect ratio
      so that they don't get squashed. Patch from Cody Russell
      on LP: #338483

 -- Ted Gould <email address hidden> Thu, 19 Mar 2009 22:39:59 -0500

Changed in pidgin-libnotify:
status: New → Fix Released
Cody Russell (bratsche)
Changed in notify-osd:
assignee: nobody → bratsche
Revision history for this message
Cody Russell (bratsche) wrote :
Mirco Müller (macslow)
Changed in notify-osd:
importance: Undecided → Medium
status: New → Confirmed
Mirco Müller (macslow)
Changed in notify-osd:
status: Confirmed → Fix Released
milestone: none → ubuntu-9.10
Curtis Hovey (sinzui)
no longer affects: null
affects: notify-osd → notify-osd (Ubuntu)
Changed in notify-osd (Ubuntu):
milestone: ubuntu-9.10 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.