Loggerhead should offer a link to see the full file diffs for a file path

Bug #333797 reported by Nicholas Allen
2
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Undecided
Michael Hudson-Doyle

Bug Description

While it is nice that loggerhead shows the diffs for all files on the same page as the revision information this is almost useless if the number of changes or size of the change is quite large. It is hard to navigate around. It would be better I think if loggerhead offered a separate page/url for changes made to each file (ie each file would get its own page which would show the complete diffs for that file). These pages would be linked to from the modified files section on the revision page.

It would also be nice for other reasons. When using bzr-email-notifier (http://launchpad.net/bzr-email-notifier) the email messages sent could contain these direct links for each modified file. At the moment they can only contain links to the annotation of that file but most likely the user would like to see the changes made instead.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Can you try the attached branch? It's not finished, but I hope you find it to be a step in the right direction.

I think the main thing that needs to be done now is to prevent the /revision/$N page becoming too large, probably by restricting to no more than say 100 lines of diff per file and no more than 10 files by default, and ways to see more (numbers subject to tweaking).

Changed in loggerhead:
assignee: nobody → mwhudson
status: New → In Progress
Revision history for this message
Nicholas Allen (nick-allen) wrote :

Great! That's exactly how I want it to work (except the ability to see the complete file diff and not just hard coded number of lines either side of the change).

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Cool, I'll polish and hopefully land it tomorrow.

The context thing should be fixed at the same time as this bug: https://bugs.edge.launchpad.net/loggerhead/+bug/297953, certainly not at the same time as this one :)

Revision history for this message
Nicholas Allen (nick-allen) wrote :

Do you know when will this be in the loggerhead trunk? It works much better than before. I would like to release a new version of bzr-email-notifier that points to the new link locations but also has a few other fixes. Looking forward to this making trunk. Thanks!

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 333797] Re: Loggerhead should offer a link to see the full file diffs for a file path

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nicholas Allen wrote:
> Do you know when will this be in the loggerhead trunk? It works much
> better than before. I would like to release a new version of bzr-email-
> notifier that points to the new link locations but also has a few other
> fixes. Looking forward to this making trunk. Thanks!

I'd like to fix things so that it doesn't make revision pages for
revisions that add lots of files really really really big. Then it can
land, I think. I'm sprinting on other stuff this week though, so it
might not get done for another few days yet. Patches welcome in the
mean time :)

Cheers,
mwh
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmuTdAACgkQeTTOPm7A7kjMIQCePK2xrqIJtgoLdAjnKrXRO1ph
nksAn0eO2xIm3G2Cq+W30BigBHhfsFje
=NOjD
-----END PGP SIGNATURE-----

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I landed this, I still need to fix the huge-page problem though...

Changed in loggerhead:
status: In Progress → Fix Committed
Martin Albisetti (beuno)
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.