amount/total column is not always large enough
Bug #324435 reported by
Michael Rooney
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
wxBanker |
Fix Released
|
Low
|
Unassigned |
Bug Description
The amount column (and I assume total as well) doesn't properly auto-size so large amounts get cut off. Perhaps it should be as wide as the largest item?
Related branches
Changed in wxbanker: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in wxbanker: | |
milestone: | none → 0.9 |
Changed in wxbanker: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yes, it should be simple enough to make this as wide as the longest entry. Getting text extents of thousands of transactions could be slow, so we should make a guess and sort transactions by highest amount, then use the text extend of the largest value. The negative sign also takes up room in every currency that I know of, so perhaps we should compare based on highest value, but multiple negative numbers by -10 to make up for the extra character.
We can do this on account setting, as well as currency change events and recalculate the extent here as well. It might be ideal to keep a "largestValue" attribute, so when transactions are added they can be compared against this and grow if necessary, without comparing everything on every addition.