SRU for cheese 2.24.2

What is that important bug, the memory leak? The version introduces quite a lot of new code which isn't really important for a stable release, and at this stage, getting proper verification results from intrepid users is hard.

Do we have a corresponding Launchpad bug for this "important bug"? If so, we should do the SRU there, if not, it's probably not worth it in the first place.

(Yes, I have become much stricter about intrepid SRUs now, since we are way past the release and should concentrate on Jaunty).

Hi Martin, I'm a Cheese developer.
I think the "important" bug Loic did talk about was the one about webcams supporting just one resolution not working properly. The other modifications are just minor leak fixes.

I explicitly asked Loic to open this SRU for the improved debug information about the webcam devices.
Particularly the commit about Vendor and Product Id is the one I care most.
As you probably know with 2.6.27 kernel series (so, with Ubuntu Intrepid) v4l decoding stuff has been moved from kernel to a userspace library, libv4l. Many webcam drivers that were developed out of mainstream have been included in mainline kernel. New code means new bugs at driver level that most of users just see as Cheese bugs. So, we received, and still receive a lot of bug reports about webcams devices not working anymore with Cheese. That patch would greatly speed up bug triaging because we wouldn't have to ask questions like "Which webcam do you have?" or "Which driver does it uses?".
Since a great part of our userbase use Ubuntu Intrepid it would be great to have at least that patch included.
Regarding the other commits, I don't really think it's so much code, just normal bugfixes that we considered unharmful enough for 2.24 series. (By the way, I thought GNOME 2.24.x series had some kind of fast path with SRUs, isn't it?)
Thank you for looking at this,
Filippo

Thanks for the detailled explanations. If we can get some people to test the package in -proposed thoroughly, I'm okay with that, especially if it will help you so much with debugging other problems. So Loic, please go ahead and upload.

> By the way, I thought GNOME 2.24.x series had some kind of fast path with SRUs, isn't it?

That was the case for Hardy, and right after Intrepid we were similarly liberal, but we really must slow down the immense rate of SRUs to intrepid, since the sheer mass of them is not just an annoyance, but also quite a high regression risk for users.

Uploaded 2.24.2-0ubuntu0+intrepid1 to intrepid-proposed for your review and validation.

No packaging change, except for an awful version number; 2.24.2-0ubuntu1 is already used in jaunty and appending a ~ would have suggested this is a backport of 2.24.2-0ubuntu1 (and it's not).

cheese (2.24.2-0ubuntu0+intrepid1) intrepid-proposed; urgency=low

  * New upstream release; LP: #309039.
    - Support for webcam with only one resolution.
    - Add some debug code.
 -- Loic Minier <email address hidden> Tue, 06 Jan 2009 18:14:16 +0100

I pushed the new upstream to my ppa and tested it from there; cheese worked fine, I took a couple of pictures, a video, tested the horizontal mirror effect and the full screen function. As expected the font in the countdown changed slightly and looks a bit better, but doesn't make a big difference.

Accepted into intrepid-proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Tested with an effect, took a couple of pictures and a video, tested full screen, checked version in about.

Tested the version 2.24.2-0ubuntu0+intrepid1 (with my Genius Eye) and everything worked fine, no regressions AFAICS. I can not comment on any bug fixes though. Where is that debug information supposed to show up?

On Thu, Jan 8, 2009 at 10:00 PM, Tormod Volden <email address hidden> wrote:
> Tested the version 2.24.2-0ubuntu0+intrepid1 (with my Genius Eye) and
> everything worked fine, no regressions AFAICS. I can not comment on any
> bug fixes though. Where is that debug information supposed to show up?

It should come up running "cheese -v".

I tried -v and --verbose with no luck. These options are not mentioned in the man page, but that would be another bug.

On Thu, Jan 8, 2009 at 11:32 PM, Tormod Volden <email address hidden> wrote:
> I tried -v and --verbose with no luck. These options are not mentioned
> in the man page, but that would be another bug.

As far as I remember we don't ship any man page, probably it comes
from a debian or ubuntu patch.
Anyway, do you mean cheese -v doesn't output anything? That's quite strange.
We use g_set_print_handler to enabler/disable debug messages, is there
any known issue with it? I don't think this bug comes from cheese...
maybe glib?
Anybody else can confirm it?

Hi Loïc, woud it be possible, IF this doesn't affect the SRU and IF Filippo agree with it, that you include the flash debug code from http://bugzilla.gnome.org/attachment.cgi?id=125572&action=view

it's for bug #297890 not a really big deal but it would be nice.

Thanks again

by the way i've tested this SRU without any problem. Thanks a lot

Sorry, it's too late for this SRU and would require another SRU. I don't run intrepid anymore and would prefer not having to do any other libv4l/cheese SRUs.

I recommend you push a patched package to your PPA or ask someone to do such an upload, then point users at the patched packages for debugging.

don't worry at all, it seems that one reporter is doing fine the debug
so it wouldn't be needed

Thanks!!

> Sorry, it's too late for this SRU and would require another SRU. I
> don't run intrepid anymore and would prefer not having to do any other
> libv4l/cheese SRUs.
>
> I recommend you push a patched package to your PPA or ask someone to do
> such an upload, then point users at the patched packages for debugging.

This bug was fixed in the package cheese - 2.24.2-0ubuntu0+intrepid1

---------------
cheese (2.24.2-0ubuntu0+intrepid1) intrepid-proposed; urgency=low

  * New upstream release; LP: #309039.
    - Support for webcam with only one resolution.
    - Add some debug code.

 -- Loic Minier <email address hidden> Tue, 06 Jan 2009 18:14:16 +0100

I had the same problem which I had logged as a bug # 311320. Obviously too many bugs going around in the same category. This fix resolved my bug.