Launchpad itself

OOPS accessing a non-existent oauth token page.

Bug #271010 reported by Diogo Matsubara
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Leonard Richardson
Launchpad itself 11.03

Bug Description

Steps to reproduce (using sample data)
1. Logged in as Sample Person, open http://launchpad.dev/+token-authorized?oauth_token=foo
2. OOPS-990S34 AttributeError: 'NoneType' object has no attribute 'is_reviewed'

Recent OOPSes: OOPS-1018S107, OOPS-1038S35, OOPS-1044S38, OOPS-1059S650, OOPS-1059S651, OOPS-1145EA324, OOPS-1145EA326, OOPS-1145EB315, OOPS-1145EB318, OOPS-1145EC326, OOPS-1145ED278

Latest one: OOPS-1845D2082

See original description

Related branches

lp:~leonardr/launchpad/bug-271010
Graham Binns (community): Approve (code)
Diff: 341 lines (+95/-119)
5 files modified
lib/canonical/launchpad/browser/oauth.py (+0/-20)
lib/canonical/launchpad/pagetests/oauth/authorize-token.txt (+16/-10)
lib/canonical/launchpad/templates/oauth-authorize.pt (+79/-6)
lib/canonical/launchpad/templates/token-authorized.pt (+0/-76)
lib/canonical/launchpad/zcml/launchpad.zcml (+0/-7)
Revision history for this message
Diogo Matsubara (matsubara) wrote :

Setting to low importance since users can only get to an invalid token page if they manually edit the url

Changed in launchpad-foundations:
importance: Undecided → Low
status: New → Triaged
Ursula Junque (ursinha)
description: updated
Ursula Junque (ursinha)
description: updated
Ursula Junque (ursinha)
description: updated
Ursula Junque (ursinha)
description: updated
Ursula Junque (ursinha)
description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

It also obviously oopses if the token was already consumed and you access the page again.

Revision history for this message
Ursula Junque (ursinha) wrote :

Forgot to sign out :/
As I was saying, it also obviously oopses if the token was already consumed and you access the page again.

Robert Collins (lifeless)
Changed in launchpad:
importance: Low → Critical
Данило Шеган (danilo)
description: updated
Revision history for this message
Leonard Richardson (leonardr) wrote :

This is happening more often now because launchpadlib now automatically attempts to exchange the request token for an access token. If it happens to do this before your browser request completes, your browser will ask for information about a nonexistent request token and you'll get this error.

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 271010] Re: OOPS accessing a non-existent oauth token page.

So, perhaps we can just say 'This token has been enabled' rather than OOPSing?

Revision history for this message
Leonard Richardson (leonardr) wrote :

One way to fix this is to have +authorize-token print out the message about how your request token is authorized, rather than redirecting to a page that tells you. (A page that you might retrieve when the request token no longer exists.)

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12503 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12503>.

Changed in launchpad:
assignee: nobody → Leonard Richardson (leonardr)
milestone: none → 11.03
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.