sysinfo should not read or write stuff in /root, but rather /etc and /var/log

Please review the attached branch.

I have the following error:

[ERROR]: landscape.sysinfo.tests.test_deployment.RunTest.test_setup_logging_logs_to_var_log_if_run_as_root

Traceback (most recent call last):
  File "/home/therve/projects/Landscape/client/trunk/landscape/tests/mocker.py", line 102, in test_method_wrapper
    result = test_method()
  File "/home/therve/projects/Landscape/client/trunk/landscape/sysinfo/tests/test_deployment.py", line 219, in test_setup_logging_logs_to_var_log_if_run_as_root
    setup_logging()
  File "/home/therve/projects/Landscape/client/trunk/landscape/sysinfo/deployment.py", line 74, in setup_logging
    os.mkdir(landscape_dir)
exceptions.OSError: [Errno 13] Permission denied: '/var/log/landscape'

Ok, that should be fixed.

+1

I have 9 test failures even after running 'make clean':

===============================================================================
[ERROR]: landscape.sysinfo.tests.test_deployment.RunTest.test_default_arguments_load_default_plugins

Traceback (most recent call last):
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/tests/mocker.py", line 102, in test_method_wrapper
    result = test_method()
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/sysinfo/tests/test_deployment.py", line 136, in test_default_arguments_load_default_plugins
    result = run([])
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/sysinfo/deployment.py", line 91, in run
    config.load(args)
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/deployment.py", line 145, in load
    self.load_configuration_file(potential_config_file)
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/deployment.py", line 174, in load_configuration_file
    config_parser.items(self.config_section))
  File "/usr/lib/python2.5/ConfigParser.py", line 544, in items
    raise NoSectionError(section)
ConfigParser.NoSectionError: No section: 'sysinfo'
===============================================================================
[ERROR]: landscape.sysinfo.tests.test_deployment.RunTest.test_format_sysinfo_gets_correct_information

Traceback (most recent call last):
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/tests/mocker.py", line 102, in test_method_wrapper
    result = test_method()
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/sysinfo/tests/test_deployment.py", line 108, in test_format_sysinfo_gets_correct_information
    run(["--sysinfo-plugins", "TestPlugin"])
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/sysinfo/deployment.py", line 91, in run
    config.load(args)
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/deployment.py", line 145, in load
    self.load_configuration_file(potential_config_file)
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/deployment.py", line 174, in load_configuration_file
    config_parser.items(self.config_section))
  File "/usr/lib/python2.5/ConfigParser.py", line 544, in items
    raise NoSectionError(section)
ConfigParser.NoSectionError: No section: 'sysinfo'
===============================================================================
[ERROR]: landscape.sysinfo.tests.test_deployment.RunTest.test_format_sysinfo_output_is_printed

Traceback (most recent call last):
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/tests/mocker.py", line 102, in test_method_wrapper
    result = test_method()
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root/landscape/sysinfo/tests/test_deployment.py", line 117, in test_format_sysinfo_output_is_printed
    run(["--sysinfo-plugins", "TestPlugin"])
  File "/home/jkakar/src/canonical/landscape-client/radix/sysinfo-no-root...

Ok, I updated this branch with some rather significant changes.

I fixed up configuration file reading to deal with missing sections, as well as to not delete unrelated sections when writing a config file. I also fixed the tests to not read global config file.

Looks good and the tests pass. +1!

Thanks, merged to trunk

Bug #271886 has a fix for this.

This bug was fixed in the package landscape-client - 1.0.21-0ubuntu1

---------------
landscape-client (1.0.21-0ubuntu1) intrepid; urgency=low

  [ Christopher Armstrong ]
  * New upstream release (LP: #271886):
    - Bug fix release:
    - Avoid the PotentialZombieWarning on landscape-client startup.
     (LP: #257346)
    - When run as root, read sysinfo configuration from /etc and and write
      logs to /var/log instead of /root. (LP: #268560)
    - Avoid ZeroDivisionErrors when /home is an autofs. (LP: #269634)
    - Don't corrupt a pid file when trying to start the client when it's
      already running. (LP: #269634)
    - Remove the pid file when shutting down the client. (LP: #257081)

  [ Mathias Gug ]
  * debian/landscape-client.init: specify the pid file and use --startas
    instead of --exec when starting landscape-client so that the init script
    doesn't fail if landscape-client is already running.

 -- Mathias Gug <email address hidden> Fri, 19 Sep 2008 17:28:08 -0400