No way for an admin to mark a branch as private in the UI

Yes there is a way to mark a branch private, but the branch visibility policy for the project must allow it.

If the policy doesn't allow private branches, then there isn't an option to make it private. If the policy states "private only" then there is no option to make private branches public. If the policy states "private" then users are able to make private branches public and public branches private.

I tried doing this on my development Launchpad instance and could *not* find the controls. Once a privacy policy is added, where are the controls for changing the individual policy?

It is on the +edit view.

There isn't a separate view for just setting the visibility. I've hesitated on writing a separate view until we had some cool AJAX stuff. It would be pretty trivial to create a view for setting the visibility though.

Fair enough. Marking as invalid.

Really though, the UI should look almost exactly the same as the bug visibility UI.

This doesn't seem to be available on +edit at the moment.

I think this is a real bug, because there's no way for users to
discover they'd have to change this.

Maybe if they try to change privacy they should be told it's disabled
for this project, and then have the option to go to a place they can
change it.

--
Martin <http://launchpad.net/~mbp/>

Martin, I'm sorry I don't really understand your comment.

It was in response to Tim's comment #1:

If the project privacy policy does not allow you to make the branch private, the control that would normally let you make it private should say this.

On Fri, Aug 14, 2009 at 1:51 AM, Martin Pool<email address hidden> wrote:
> It was in response to Tim's comment #1:
>
> If the project privacy policy does not allow you to make the branch
> private, the control that would normally let you make it private should
> say this.
>

Oh right. That makes sense & I think that's a good UI.

FWIW just had a real use case where a public branch needed to be made private, and had to resort to SQL to make it so.

Would be happy with an admin only toggling ability - even with big warnings that this may be undesirable. ?

Steve, I think that if we had a control for this, it allow for admin override.

Tim, it seems to me that the control for this should behave in exactly the same way as the bug privacy control currently does, and maybe even re-use the same code.

Got bitten by this again, this time for a branch for a security fix in LP itself. Increasing importance because this will happen again.

And again, for another security fix per a request from Abel.

And again, for another request from Abel. Is this being actively worked on?

No, sorry.

On Thu, 26 Nov 2009 08:08:03 Michael Hudson wrote:
> No, sorry.

I'll hack something up for admins today.

Tim

Admin only ability to allow any public branch to be marked private.