five-a-day

"add-5-a-day BUGNR" silently stopped working

Bug #264853 reported by Daniel Hahler
4
Affects Status Importance Assigned to Milestone
five-a-day
Fix Released
Undecided
Unassigned

Bug Description

"add-5-a-day BUGNR" used to call "5-a-day add BUGNR" (or something similar), but nowadays, it silently does nothing.

Either this behavior should get re-added or the add-5-a-day => 5-a-day symlink should get removed.

In particular, without any command given or something invalid like "5-a-day add BUGNR", usage info and an error message (if there's something unknown given) should get displayed.
This includes an exit code != 0 in case of an error.

This is with 0.52~hardy1.

See original description
Daniel Hahler (blueyed)
description: updated
description: updated
Revision history for this message
Daniel Holbach (dholbach) wrote :

This was removed during the fix of the "use getopt" bug.

Changed in five-a-day:
status: New → Confirmed
Revision history for this message
Benjamin Drung (bdrung) wrote :

Now you have to use "5-a-day --add BUGNR" or shorter "5-a-day -a BUGNR".

To solve this bug, there are two options:
1. assume "--add" if no parameter is present
2. remove symlink and replace it by an short script (running "5-a-day --add BUGNR" and passing all parameters except --add-{teams,tags} and --remove-{teams,tags})
Daniel, what do you think?

The silent dying should be fixed.

Revision history for this message
Daniel Holbach (dholbach) wrote :

I'd prefer 1) with a check of sys.argv[0]. There's still "update-signature" shipped (as a symlink) as well.

Benjamin Drung (bdrung)
Changed in five-a-day:
status: Confirmed → Fix Committed
Daniel Holbach (dholbach)
Changed in five-a-day:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.