Ubuntu
gtk-sharp2 package

Fix memory leak in IconTheme.LoadIcon

Bug #254855 reported by Jason Smith
4
Affects Status Importance Assigned to Milestone
gtk-sharp2 (Debian)
Fix Released
Unknown
gtk-sharp2 (Ubuntu)
Fix Released
Medium
Unassigned
Nominated for Hardy by Chris Halse Rogers

Bug Description

Binary package hint: gtk-sharp2

http://anonsvn.mono-project.com/viewcvs/trunk/gtk-sharp/gtk/Gtk.metadata?rev=109594&r1=107494&r2=109594

Applying that patch fixes a huge memory leak in many programs.

Related branches

lp:ubuntu/lucid/gtk-sharp2
Jason Smith (jassmith)
Changed in gtk-sharp2:
assignee: nobody → raof
Chris Halse Rogers (raof)
Changed in gtk-sharp2:
assignee: raof → nobody
Chris Halse Rogers (raof)
Changed in gtk-sharp2:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Chris Halse Rogers (raof) wrote :

Here's a debdiff applying the upstream patch.

It builds fine, but I haven't tested it thoroughly yet.

Revision history for this message
Chris Halse Rogers (raof) wrote :

Tested against GNOME Do, F-Spot, and Monsoon, and everything seems to be hunky-dory.

It also does as claimed, and plugs a memory leak. This leak is easily visible by summoning Do, typing a single letter (say 'a'), and holding the down key to scroll through the entire results list, which causes a lot of icons to be loaded. Prior to the application of this patch, doing this a couple of times would result in Do's memory usage increasing monotonicly. After the application of this patch, following this procedure will result in Do's memory usage increasing and then decreasing as the GC kicks in.

Revision history for this message
Colin Watson (cjwatson) wrote :

Uploaded, thanks! The only change I made was to fix the debian/changelog syntax; it has to be "LP: #nnnnnn" rather than "LP: nnnnnn" otherwise the bug won't get closed.

I also forwarded this to Debian.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gtk-sharp2 - 2.12.1-1ubuntu2

---------------
gtk-sharp2 (2.12.1-1ubuntu2) intrepid; urgency=low

  * debian/patches/02_icon_theme_memory_leak
    + Patch from upstream svn. Fixes a memory leak where LoadIcon would
    leak Pixbufs (LP: #254855).

 -- Christopher James Halse Rogers <email address hidden> Thu, 04 Sep 2008 21:01:27 +1000

Changed in gtk-sharp2:
status: Confirmed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gtk-sharp2:
status: Unknown → New
Revision history for this message
Chris Halse Rogers (raof) wrote :

This looks like it should be SRU worthy; the patch is small, from upstream, and the problem it fixes is pretty serious for some apps.

I'll whip up a debdiff against the Hardy package soon.

Bug Watch Updater (bug-watch-updater)
Changed in gtk-sharp2:
status: New → Fix Committed
Bug Watch Updater (bug-watch-updater)
Changed in gtk-sharp2:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.