Bazaar

serve --quiet is not quiet

Bug #252834 reported by RLVJ
4
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Gordon Tyler
Bazaar 2.1.0b4 "san francisco airport"

Bug Description

Bug:
Since --quiet is likely to be used in serving, it must in some scenarios be absolutely silent.
It may have it's stdout and sterr file descriptors closed before being exec()ed.

If bzr serve runs in a separate process, it should close it's own stdout and stderr; in any case, it should completely avoid output when called with --quiet.

Strict silence might not be as important for other commands (branch, pull, ...).

Perhaps quiet or another option should be a command, which after being executed will silence the bzr instance for all commands until verbosity is reactivated.

See original description
Tags: easy ui

Related branches

lp:~doxxx/bzr/quiet-serve
Merged into lp:bzr
Vincent Ladeuil: Needs Fixing
Robert Collins (community): Approve
Diff: 158 lines (+68/-43)
2 files modified
bzrlib/tests/__init__.py (+16/-4)
bzrlib/tests/blackbox/test_serve.py (+52/-39)
lp:~vila/bzr/integration
Vincent Ladeuil: Approve
Diff: 31 lines (+4/-4)
2 files modified
bzrlib/lazy_regex.py (+3/-3)
doc/en/release-notes/bzr-2.7.txt (+1/-1)
Revision history for this message
James Westby (james-w) wrote :

Hi,

Do you see anything else than the "listening on port: " message?

Thanks,

James

Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
RLVJ (nathan-johnson) wrote :

The only message I see is: "listening on port: ".

description: updated
Revision history for this message
RLVJ (nathan-johnson) wrote :

In BASh, all default file descriptors can be closed by
0<&- 1<&- 2<&- bzr serve --quiet
which causes bzr to quit.
Only closing stdout & stderr, as in
1<&- 2<&- bzr serve --quiet
does not cause bzr to quit.

Revision history for this message
Gordon Tyler (doxxx) wrote :

Cannot reproduce in 2.1.0b3. "bzr serve -q" produces no output to the console.

Revision history for this message
Gordon Tyler (doxxx) wrote :

I'm going to write a test case for this.

Changed in bzr:
assignee: nobody → Gordon Tyler (doxxx)
Gordon Tyler (doxxx)
Changed in bzr:
status: Confirmed → In Progress
Vincent Ladeuil (vila)
Changed in bzr:
status: In Progress → Fix Committed
Vincent Ladeuil (vila)
Changed in bzr:
status: Fix Committed → Fix Released
milestone: none → 2.1.0b4
status: Fix Released → Fix Committed
John A Meinel (jameinel)
Changed in bzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.