bzr add: exceptions.AttributeError: children on add

Hi,

Thanks for taking the time to report this bug.

It looks like bug 192859, but that is about a symlink, whereas
it appears your tree changes a file to a directory. Is that correct?

Thanks,

James

Hello James,

From: <email address hidden> [mailto:<email address hidden>] On
>
> Hi,
>
> Thanks for taking the time to report this bug.
>
Thanks for taking care of the bug ;-)

> It looks like bug 192859, but that is about a symlink, whereas
> it appears your tree changes a file to a directory. Is that correct?
>
Yes.

Cheers,

   Markus

jw2328@flash:/tmp:1002:0% bzr init aaa
cd aaa
jw2328@flash:/tmp:1003:0% cd aaa
jw2328@flash:/tmp/aaa:1004:0% mkdira
zsh: command not found: mkdira
zsh: exit 127 mkdira
jw2328@flash:/tmp/aaa:1005:127% mkdir a
jw2328@flash:/tmp/aaa:1006:0% touch a/a
jw2328@flash:/tmp/aaa:1007:0% bzr add
added a
added a/a
jw2328@flash:/tmp/aaa:1008:0% bzr ci -m foo
Committing to: /tmp/aaa/
added a
added a/a
Committed revision 1.
jw2328@flash:/tmp/aaa:1009:0% mv a b
jw2328@flash:/tmp/aaa:1010:0% ln -s b a
jw2328@flash:/tmp/aaa:1011:0% bzr add
added b
added b/a
jw2328@flash:/tmp/aaa:1012:0% ls
total 1
lrwxrwxrwx 1 jw2328 jw2328 1 2008-07-28 13:19 a -> b
drwxr-xr-x 2 jw2328 jw2328 1024 2008-07-28 13:19 b
jw2328@flash:/tmp/aaa:1013:0% bzr ci -m asdf
Committing to: /tmp/aaa/
modified a
added b
bzr: ERROR: exceptions.AttributeError: children

Traceback (most recent call last):
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commands.py", line 857, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/builtins.py", line 2340, in run
    author=author)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/workingtree_4.py", line 242, in commit
    result = WorkingTree3.commit(self, message, revprops, *args, **kwargs)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/decorators.py", line 192, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/mutabletree.py", line 197, in commit
    revprops=revprops, *args, **kwargs)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commit.py", line 355, in commit
    self._update_builder_with_changes()
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commit.py", line 655, in _update_builder_with_changes
    self._populate_from_inventory(specific_files)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commit.py", line 783, in _populate_from_inventory
    content_summary)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/commit.py", line 825, in _record_entry
    self.parent_invs, path, self.work_tree, content_summary)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/repository.py", line 268, in record_entry_contents
    self.new_inventory.add(ie)
  File "/home/jw2328/devel/bzr/bzr.dev/bzrlib/inventory.py", line 1074, in add
    if entry.name in parent.children:
AttributeError: children

bzr 1.6b3 on python 2.5.2 (linux2)
arguments: ['/home/jw2328/bin//bzr', 'ci', '-m', 'asdf']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_GB.UTF-8'
plugins:
  addremove /home/jw2328/.bazaar/plugins/addremove [unknown]
  bisect /home/jw2328/.bazaar/plugins/bisect [1.1.0pre0]
  builddeb /home/jw2328/.bazaar/plugins/builddeb [0.92.0dev0]
  bzrtools /home/jw2328/.bazaar/plugins/bzrtools [1.6.0]
  dbus /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus [unknown]
  e...

Hi,

I reproduced a different bug.

There is definitely some similarity with bug 192859 here, but
it seems like there may be between 1 and 3 bugs.

Thanks,

James

Hi,

I can't reproduce this on current bzr.dev. Could you please
provide steps to reproduce this in a simple test branch, and
if possible test on a newer version of bzr.

Thanks,

James

Reproduced with 1.8rc1:

avallach:/tmp% bzr init p
avallach:/tmp% cd p
avallach:/tmp/p% touch a
avallach:/tmp/p% bzr add a
added a
avallach:/tmp/p% bzr ci -m a
Committing to: /tmp/p/
added a
Committed revision 1.
avallach:/tmp/p% rm a
avallach:/tmp/p% mkdir a
avallach:/tmp/p% touch a/bla
avallach:/tmp/p% bzr add a
<breakage>

A workaround seems to be to run "bzr status" before "bzr add a"

I got it with bzr2.1.0. For some reason I already had a directory ("kuku/muku") without any file under it in my repo. So when I tried to add a file under this directory I got:

------------------------------8<--------------------------------------
adding kuku/muku
bzr: ERROR: exceptions.AttributeError: children

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 853, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 1055, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 661, in run_argv_aliases
    return self.run_direct(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 665, in run_direct
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/cleanup.py", line 122, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/cleanup.py", line 156, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 659, in run
    no_recurse, action=action, save=not dry_run)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 49, in tree_write_locked
    return unbound(self, *args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 417, in smart_add
    added.extend(_add_one_and_parent(self, inv, None, rf, kind, action))
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 671, in _add_one_and_parent
    _FastPath(osutils.dirname(path.raw_path)), 'directory', action)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 674, in _add_one_and_parent
    _add_one(tree, inv, parent_ie, path, kind, action)
  File "/usr/lib/python2.5/site-packages/bzrlib/mutabletree.py", line 691, in _add_one
    inv.add(entry)
  File "/usr/lib/python2.5/site-packages/bzrlib/inventory.py", line 1301, in add
    if entry.name in parent.children:
AttributeError: children

bzr 2.1.0 on python 2.5.1 (Linux-2.6.18-92.el5-i686-with-redhat-5.2-Tikanga)
arguments: ['/usr/bin/bzr', 'add', 'kuku/muku/myfile.h']
encoding: 'ISO-8859-1', fsenc: 'ISO-8859-1', lang: 'en_US'
plugins:
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [2.1.0]
  netrc_credential_store /usr/lib/python2.5/site-packages/bzrlib/plugins/netrc_credential_store [2.1.0]
  news_merge /usr/lib/python2.5/site-packages/bzrlib/plugins/news_merge [2.1.0]
  svn /afs/haifa/home/vitali/.bazaar/plugins/svn [1.0.2]
------------------------------8<--------------------------------------

The workaround was to remove this directory:
> bzr rm --kep kuku/muku

Similar to bug 205636 but unlike that one bug 192859 didn't resolve it. Can do a similar kind of fix though.