openvpn init script lacks the 'status' action

Nathan: fyi, 2.1~rc8-1 was synced to intrepid recently to fix a couple of bugs. It still misses the status action in the initscript so this bug is still open.

On Tue, Jul 29, 2008 at 4:20 AM, Thierry Carrez
<email address hidden> wrote:
> Nathan: fyi, 2.1~rc8-1 was synced to intrepid recently to fix a couple
> of bugs. It still misses the status action in the initscript so this bug
> is still open.

Nathan-

Can you re-base your diff against the current openvpn?

:-Dustin

The trick is that openVPN isn't just "started" or "stopped". Starting it will start zero or more OpenVPN processes, based on available VPN configurations and AUTOSTART setting.

After discussion, it appears logical to have the status action list the VPNs available and their specific status, then consider it a global success when all VPNs that should be autostarted are running, and failure otherwise. If no VPN is configured, then it should be considered a failure.

Proposed debdiff

This should cover all the cases...

service openvpn status = lists the status of all defined VPNs and...
  if AUTOSTART="all" (or AUTOSTART not defined) -> returns 0 if all defined VPNs are running
  if AUTOSTART="none" -> always returns non-zero
  if AUTOSTART="vpn1 vpn2" -> returns 0 if vpn1 and vpn2 are defined and running

service openvpn status vpn1 vpn2 = lists the status of vpn1 and vpn2 and returns 0 if vpn1 and vpn2 are running

Better debdiff with a fix for a corner case

We might want to fix another bug in the same upload. See debdiff attached to bug 264966.

This bug was fixed in the package openvpn - 2.1~rc9-3ubuntu2

---------------
openvpn (2.1~rc9-3ubuntu2) intrepid; urgency=low

  * debian/openvpn.init.d:
    - Added 'status' action to init script (LP: #251641)
    - Restored per-VPN result messages by using log_action_begin_msg and
      one log_daemon_msg per VPN instead of log_progress_msg (LP: #264966)
  * debian/control: Added lsb-base>=3.2-14 depend to allow status_of_proc()

 -- Thierry Carrez <email address hidden> Tue, 09 Sep 2008 10:45:45 +0200