bzr missing gives confusing 'up to date' message

Bug #250296 reported by Timothy Smith
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Low
Unassigned

Bug Description

Using current bzr.dev, 'bzr missing --this OTHER-REPO' says "This branch is up to date", when it should say "This branch has no new revisions".

To repeat:

cd /tmp
mkdir a
cd a
bzr init
bzr branch . ../b
echo foo > a_file.txt
bzr add a_file.txt
bzr commit -m 'change'
bzr missing --other ../b
cd ../b
bzr missing --this ../a
bzr missing

Output, and suggestions for correct wording:

$ mkdir a
$ cd a
$ bzr init
$ bzr branch . ../b
Branched 0 revision(s).
$ echo foo > a_file.txt
$ bzr add a_file.txt
added a_file.txt
$ bzr commit -m 'change'
Committing to: /tmp/other-bug/a/
added a_file.txt
Committed revision 1.
$ bzr missing --other ../b
Other branch is up to date.

### Oops, actually *this* branch is up-to-date, but the other branch
### is missing a revision.
### Suggested wording: "This branch is up to date." Or, "Other branch
### has no new revisions."

$ cd ../b
$ bzr missing --this ../a
This branch is up to date.

### Oops, actually this branch is missing a revision, it's the *other*
### branch which is up-to-date.
### Suggested wording: "Other branch is up to date." Or, "This branch
### has no new revisions."

$ bzr missing
Using last location: /tmp/other-bug/a/
You are missing 1 revision(s):
------------------------------------------------------------
revno: 1
committer: Carl Committer <email address hidden>
branch nick: a
timestamp: Sun 2008-07-20 11:15:12 -0600
message:
  change

### Yes, this is correct. It would be more professional to
### say "This branch is missing" instead of "You are missing".

$ bzr version
Bazaar (bzr) 1.6b4
  from bzr checkout /home/ccomm/lib/bzr.dev
    revision: 3565
    revid: <email address hidden>
    branch nick: bzr.dev
  Python interpreter: /usr/bin/python 2.5.2
  Python standard library: /usr/lib/python2.5
  bzrlib: /home/ccomm/lib/bzr.dev/bzrlib
  Bazaar configuration: /home/ccomm/.bazaar
  Bazaar log file: /home/ccomm/.bzr.log

Related branches

Revision history for this message
James Westby (james-w) wrote :

Hi,

Thanks for reporting these problems, I agree.

Thanks,

James

Changed in bzr:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Doug Lee (dgl-dlee) wrote :

Trivial to be sure, but in case it speeds things, here's a patch.

Martin Pool (mbp)
Changed in bzr:
status: Confirmed → In Progress
Revision history for this message
Martin Pool (mbp) wrote :

Thanks Doug, that looks good.

Can you please

 * mention this in news
 * update any tests that fail; 'bzr selftest missing' will probably find them; there _should_ be tests for the existing behaviour
 * push a branch for this and propose a merge

Revision history for this message
John A Meinel (jameinel) wrote :

I don't think this is actively being worked on, but it is a patch that needs work.

Changed in bzr:
status: In Progress → Confirmed
tags: added: patch-needswork
Revision history for this message
Andrew Bennetts (spiv) wrote :

Thomi Richards has kindly tweaked Doug's patch and submitted it: <https://code.launchpad.net/~thomir/bzr/fix-bug-250296/+merge/69206>.

Doug: I believe you need to execute Canonical's Contributor License Agreement before we can accept the patch: <http://www.canonical.com/contributors>.

Thanks Doug and Thomi!

Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
Changed in bzr:
status: Confirmed → Fix Released
tags: removed: check-for-breezy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.