Launchpad itself

setPreferredEmail should require activated accounts

Bug #248518 reported by Curtis Hovey
8
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Edwin Grubbs
Launchpad itself 10.04

Bug Description

Person.setPreferredEmail() was responsible for activating accounts before Account was split from Person.
Callsites should ensure the person has an active account /before/ calling setPreferredEmail() so that
the method has less responsability..

Related branches

lp:~edwin-grubbs/launchpad/bug-248518-setPreferredEmail
Curtis Hovey (community): Approve (code)
Diff: 120 lines (+23/-20)
5 files modified
lib/lp/bugs/browser/bugalsoaffects.py (+1/-1)
lib/lp/bugs/browser/tests/bugtask-adding-views.txt (+0/-1)
lib/lp/registry/doc/person.txt (+13/-5)
lib/lp/registry/model/person.py (+0/-11)
lib/lp/testing/factory.py (+9/-2)
Curtis Hovey (sinzui)
Changed in launchpad:
status: New → Confirmed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Undecided → Low
status: Confirmed → Triaged
Curtis Hovey (sinzui)
tags: added: tech-debt
removed: cleanup
Curtis Hovey (sinzui)
visibility: private → public
Revision history for this message
Curtis Hovey (sinzui) wrote :

Because Launchpad relies on the SSO and it does the password reset, Person.setPreferredEmail() should never be called with a deactivated account. The acount logic can be removed.

Changed in launchpad-registry:
milestone: none → series-10.05
tags: added: trivial
removed: registry
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
status: Triaged → In Progress
summary: - setPreferredEmail activated accounts
+ setPreferredEmail should require activated accounts
Edwin Grubbs (edwin-grubbs)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10781 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10781>

Changed in launchpad-registry:
milestone: series-10.05 → 10.04
tags: added: qa-needstesting
Curtis Hovey (sinzui)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 248518 Fix released

Fixed released in launchpad-project 10.04.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.