Awn

patterns must be manually disabled for themes without them

Bug #246967 reported by Michael Rooney
2
Affects Status Importance Assigned to Milestone
Awn
Fix Released
Undecided
Mark Lee

Bug Description

Hello, it appears that the pattern option gets set no matter what when applying a theme, even when applying a theme which does not use a pattern. For example, try "Scaled Black Theme" or "Art of Dark Cappuccino" from http://wiki.awn-project.org/index.php?title=Themes. When you apply them, you have to go to the General tab, then "Pattern Engine", and disable the "Enable pattern" checkbox. If it was previously disabled, you will have to check it and then uncheck it. Otherwise just uncheck it. Now the theme will display correctly, with separators and proper gradients, borders, etc.

You can even go right back to the Themes tab, and click Apply again on the very same theme, and it will enable the pattern again and you will have to go back and do this again.

I have noticed this for awhile and feel like there should be a duplicate bug, but I can't seem to find one. I feel like many people have themes which aren't actually displaying at all as intended as a result of this.

Related branches

Revision history for this message
black (blackborn) wrote :

Thanks for posting the bugreport.

This is actually a very odd bug. I will explain. The values of every option are stored in the theme file and are readed like strings. The python bool function return always true if the input is a string, so bool("False") is true. And that was the problem. The theme says that the pattern_engine needs to be "False" and awn-manager sees True.

I've made a patch, so it will not take long before this issue is solved in the trunk.

Changed in awn:
status: New → In Progress
Revision history for this message
Michael Rooney (mrooney) wrote :

This fixes the issue for me and the patch looks good, thanks! This should really make it into 0.2.8 (and the Intrepid package if 0.2.8 doesn't make it) or most of the themes will not look much like their images, and separators won't be shown on them either. Basically without this patch all non-patterned themes (a lot of them) are borked.

Mark Lee (malept)
Changed in awn:
assignee: nobody → malept
milestone: none → 0.2.8
Revision history for this message
Mark Lee (malept) wrote :

Fixed in trunk in revision 471. It will be in the 0.2.7 branch shortly.

Changed in awn:
status: In Progress → Fix Committed
moonbeam (rcryderman)
Changed in awn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.