Olive on Windows does not find mapped drives

Bug #244308 reported by Kevin Light
2
Affects Status Importance Assigned to Milestone
Bazaar GTK+ Frontends
Fix Released
Undecided
Unassigned

Bug Description

On Windows the drive letters (alphabet) are iterated over to determine which drives are valid. The iteration only checks for "win32file.DRIVE_FIXED" which does not include mapped drives, "win32file.DRIVE_REMOTE. This can cause a traceback if Olive is started from a mapped drive as the current drive is selected from the list when the dialog is created.

Is there any reason to not make mapped drives available in the drop down list?

Mapped drives are accessible after Olive has started. The drive/path must be manually entered in the "Jump to" box.

I've included a patch to include the mapped drives when the drives are scanned. This patch is against the trunk/0.95 release.

Related branches

Revision history for this message
Kevin Light (klight) wrote :
Revision history for this message
Jelmer Vernooij (jelmer) wrote : Re: [Bug 244308] [NEW] Olive on Windows does not find mapped drives

Hi Kevin,

Am Montag, den 30.06.2008, 17:36 +0000 schrieb Kevin Light:
> On Windows the drive letters (alphabet) are iterated over to determine
> which drives are valid. The iteration only checks for
> "win32file.DRIVE_FIXED" which does not include mapped drives,
> "win32file.DRIVE_REMOTE. This can cause a traceback if Olive is started
> from a mapped drive as the current drive is selected from the list when
> the dialog is created.
>
> Is there any reason to not make mapped drives available in the drop down
> list?
>
> Mapped drives are accessible after Olive has started. The drive/path
> must be manually entered in the "Jump to" box.
>
> I've included a patch to include the mapped drives when the drives are
> scanned. This patch is against the trunk/0.95 release.
I don't think there is a particular reason Olive doesn't try
DRIVE_REMOTE atm.

Thanks for the patch! Any chance you can send it to the bzr-gtk mailing
list with [MERGE] in the subject? You may get a message back saying only
members' posts are accepted, but it should be possible for me to
manually approve your message even while you're not subscribed.

Cheers,

Jelmer
--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

Revision history for this message
Jasper Groenewegen (colbrac) wrote :

Patch committed to trunk as rev 531

Changed in bzr-gtk:
status: New → Fix Committed
Jelmer Vernooij (jelmer)
Changed in bzr-gtk:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.