1/0 Music

Bug #241727 reported by Andrew
2
Affects Status Importance Assigned to Milestone
Entertainer Media Center
Fix Released
Low
Matt Layman

Bug Description

When you have no music in your music collection, or just don't set anywhere for entertainer to index, it shoes it as having 1/0 music tracks, shouldn't this be replaced with a screen like you have in Videos>Tv Shows when you have no TV Shows?

Related branches

Andrew (and471)
description: updated
Revision history for this message
Joshua Scotton (joshuascotton) wrote :

Quite true, thanks for reporting this

Changed in entertainer:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Matt Layman (mblayman) wrote :

I'll see what it will take to add this.

Changed in entertainer:
assignee: nobody → laymansterms
status: Confirmed → In Progress
Paul Hummer (rockstar)
Changed in entertainer:
milestone: none → entertainer-0.2
Paul Hummer (rockstar)
Changed in entertainer:
assignee: laymansterms → z-droid
Revision history for this message
Matt Layman (mblayman) wrote :

Mattalui, have you had any chance to work on this? Do you need some help? This is targeted to 0.2 which is happening soon.

Revision history for this message
Paul Hummer (rockstar) wrote : Re: [Bug 241727] Re: 1/0 Music

> Mattalui, have you had any chance to work on this? Do you need some
> help? This is targeted to 0.2 which is happening soon.
>

Matt, could you take a look at it? I know he's feeling overwhelmed at
the amount of code that is in Entertainer. I'm sure there will be
occasions for him to fix other bugs, but this is something that needs to
happen.

--
Paul Hummer
Launchpad Code Team

Revision history for this message
Joshua Scotton (joshuascotton) wrote :

This would be down to setting the current selection position to 1 without checking if there's any music first.
See line 207 of frontend/gui/screens/music_screen.py for an example
This shows up in about 5 of the screens.

Revision history for this message
Matt Layman (mblayman) wrote :

Josh, I think the correct solution here is not to fix the list indicator problem, but to never create the list indicator at all in this situation. I think that the photoalbums_screen illustrates this the best. If there are no photos in the image library, call the method to generate a "no photos" message. I'll do something similar, but I'll use the music library's number_of_tracks method and generate the "no music" message if the number of tracks is 0. I think I can have a fix for this done by later this evening.

Matt Layman (mblayman)
Changed in entertainer:
assignee: z-droid → laymansterms
Paul Hummer (rockstar)
Changed in entertainer:
status: In Progress → Fix Committed
Paul Hummer (rockstar)
Changed in entertainer:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.