sourcepackagerelease.sourcepackage() is dangerous

Bug #241298 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

Celso says:

"Sampledata is sort of inconsistent having a SPR uploaded to hoary
(mozilla-firefox_0.9) and also published in warty, this is very
counter intuitive, considering warty was released before hoary was
opened.

"However, the fact it is *very* broken is actually good, because
DistroSeriesSourcePackageRelease.sourcepackage, which is in fact
SourcePackageRelease.sourcepackage (DSSPR decorates SPR) is not what
you want to use as 'parent'.

"The SPR.sourcepackage property uses the SPR.upload_distroseries to
build a SourcePackage object and it won't be as useful as it looks
once we start supporting derivation. Let's say a source package
version uploaded to debian gets published in ubuntu (debian-sync,
which we intend to do very early in 3.0), the navigation would
mistakenly jump from one distribution to another.

"Summing up, SPR.sourcepackage is dangerous and should be renamed (or
removed)..."

Related branches

Celso Providelo (cprov)
Changed in soyuz:
importance: Undecided → Wishlist
milestone: none → 1.99
status: New → Triaged
Changed in soyuz:
milestone: 1.99 → none
Curtis Hovey (sinzui)
tags: added: tech-debt
removed: cleanup
Curtis Hovey (sinzui)
visibility: private → public
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.